From: Felix Fietkau <nbd@openwrt.org>
To: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] ath9k: Kick start paprd calibration whenever operating channel changes
Date: Tue, 21 Sep 2010 12:25:01 +0200 [thread overview]
Message-ID: <4C9887FD.6070505@openwrt.org> (raw)
In-Reply-To: <20100921101757.GA4229@vasanth-laptop>
On 2010-09-21 12:17 PM, Vasanthakumar Thiagarajan wrote:
> On Tue, Sep 21, 2010 at 03:36:28PM +0530, Felix Fietkau wrote:
>> That seems like code duplication to me. The caldata already has the
>> channel number and the channel flags. ath9k_hw_reset() clears the entire
>> caldata whenever that changes. Because of that, ah->caldata->paprd_done
>> should have already been set to zero automatically after the reset
>> triggered by an operating channel change.
>> Is that part not working, or why did you write this patch?
>> Either way, we should not have a separate check just for paprd, it
>> belongs to the other calibrations.
>
> I don't want to do paprd again whenever coming back from off-channel
> (like during background scanning).
That's not what it does. The caldata is only reset after *operating*
channel changes, not just after off-channel activity.
The reason this works is that for off-channel activity, the caldata
pointer is not passed to the hw reset function, so it can't reset any
data there. The intention behind that is that offchannel activity should
never trigger any long calibration activity, nor change the state of the
existing long calibration data.
- Felix
next prev parent reply other threads:[~2010-09-21 10:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 5:54 [PATCH 1/2] ath9k: Fix tx struck state with paprd Vasanthakumar Thiagarajan
2010-09-21 5:54 ` [PATCH 2/2] ath9k: Kick start paprd calibration whenever operating channel changes Vasanthakumar Thiagarajan
2010-09-21 10:06 ` Felix Fietkau
2010-09-21 10:17 ` Vasanthakumar Thiagarajan
2010-09-21 10:25 ` Felix Fietkau [this message]
2010-09-21 10:32 ` Vasanthakumar Thiagarajan
2010-09-21 10:42 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9887FD.6070505@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).