From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.candelatech.com ([208.74.158.172]:43148 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754323Ab0IUSEe (ORCPT ); Tue, 21 Sep 2010 14:04:34 -0400 Message-ID: <4C98F3AB.20206@candelatech.com> Date: Tue, 21 Sep 2010 11:04:27 -0700 From: Ben Greear MIME-Version: 1.0 To: Felix Fietkau CC: "ath9k-devel@lists.ath9k.org" , "linux-wireless@vger.kernel.org" , Johannes Berg Subject: Re: [ath9k-devel] ath9k, multiple stations, and AMPDUs References: <4C9841BA.4080700@candelatech.com> <4C98848C.70005@openwrt.org> <4C98A022.7020106@candelatech.com> <4C98A2C4.8060108@openwrt.org> <4C98EAA1.7050908@candelatech.com> <4C98F2D8.8020602@openwrt.org> In-Reply-To: <4C98F2D8.8020602@openwrt.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/21/2010 11:00 AM, Felix Fietkau wrote: > On 2010-09-21 7:25 PM, Ben Greear wrote: >> On 09/21/2010 05:19 AM, Felix Fietkau wrote: >>> On 2010-09-21 2:08 PM, Ben Greear wrote: >> >>>> If you have any more details on this, please let me know. I'm going to >>>> attempt to fix it...I certainly have a good test case :) >>> ath_tx_complete_aggr completes an A-MPDU frame, which typically triggers >>> the release of the next A-MPDU to the hw queue. >>> To keep track of the Block ACK window, it needs to look up the TID, for >>> which it needs a STA pointer. At that level, the driver typically >>> doesn't have access to the vif. >>> >>> It might be possible to fix this by adding another sta lookup helper >>> function in mac80211 that takes another address argument for the BSSID, >>> so that it can get the sta entry for the correct vif. I don't know if >>> Johannes wants something like that though. >> >> Could we just poke a pointer to the STA into the ath_buf structure? > No, that doesn't work because of RCU. Would it also be bad to use skb->dev to find an STA? Thanks, Ben > > - Felix > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Greear Candela Technologies Inc http://www.candelatech.com