Re: [mac80211/ath9k] mac80211/ath9k: Support AMPDU with multiple VIFs.

[Ben Greear <greearb@candelatech.com>]

On 09/21/2010 12:19 PM, Johannes Berg wrote:
> On Tue, 2010-09-21 at 12:17 -0700, Ben Greear wrote:
>> The tx path doesn't seem to pass in more than the hardware and the skb,
>> and we don't always need to lookup the VIF, so looking it up early is
>> probably a waste.
>>
>> mac80211 could be changed to pass in the VIF in the xmit path,
>> and then we could make sure that is passed through the entire
>> xmit process, but that would touch a lot of drivers and code.
>
> It does pass this through in the skb's CB.

>> I'm more than happy to test any patches if someone thinks up
>> a different approach.
>
> I just don't want drivers using struct net_device pointers anywhere,
> because they shouldn't have to worry about them.

Can we just use:
sta = tx_info->control.sta
in ath_tx_complete_aggr()
?

Thanks,
Ben

>
> johannes


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com