From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.candelatech.com ([208.74.158.172]:50929 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754380Ab0IWSsS (ORCPT ); Thu, 23 Sep 2010 14:48:18 -0400 Message-ID: <4C9BA0EE.9090206@candelatech.com> Date: Thu, 23 Sep 2010 11:48:14 -0700 From: Ben Greear MIME-Version: 1.0 To: Johannes Berg CC: linux-wireless@vger.kernel.org Subject: Re: [mac80211] mac80211: Support receiving data frames on multiple vifs. References: <1285018776-21795-1-git-send-email-greearb@candelatech.com> <1285051641.3710.8.camel@jlt3.sipsolutions.net> <4C9B5CE4.9040806@candelatech.com> <1285250792.3770.110.camel@jlt3.sipsolutions.net> <4C9B8703.7070907@candelatech.com> <1285267335.3770.400.camel@jlt3.sipsolutions.net> In-Reply-To: <1285267335.3770.400.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/23/2010 11:42 AM, Johannes Berg wrote: > On Thu, 2010-09-23 at 09:57 -0700, Ben Greear wrote: > >>> Well, I personally would've tried to reduce the code duplication between >>> the two loops, but right now I'm not sure I see how to. >> >> I could move some of the rx setup code into prepare_for_handlers, >> but not sure how much that would help readability. >> >> In my opinion, that would be a good candidate for a followup >> patch instead of adding that to this patch, though. > > Yeah, I can agree with that. > > I have a patch that also touches this area, I'll let you get this one in > first and rebase it. Thanks! I'm currently testing VAP + STA on same hardware concurrently with ath5k, and seems the VAP doesn't receive any packets. When I get that sorted, I'll work on the rx setup code minimization patch. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com