Re: [RFC] mac80211: sets basic rate set parameter for IBSS creator

[Mohammed Shafi <mshajakhan@atheros.com>]

On Tuesday 28 September 2010 02:32 PM, Johannes Berg wrote:
> On Tue, 2010-09-28 at 13:59 +0530, Mohammed Shafi Shajakhan wrote:
>    
>> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>
>> This fix sets the basic rate set parameter for IBSS creator when the
>> basic rates are not explicitly specified in the user space.
>>
>> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>> ---
>>   net/mac80211/ibss.c |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
>> index 1a3aae5..e117155 100644
>> --- a/net/mac80211/ibss.c
>> +++ b/net/mac80211/ibss.c
>> @@ -541,6 +541,9 @@ static void ieee80211_sta_create_ibss(struct ieee80211_sub_if_data *sdata)
>>   		capability |= WLAN_CAPABILITY_PRIVACY;
>>   	else
>>   		sdata->drop_unencrypted = 0;
>> +	if (ifibss->basic_rates == 0)
>> +		ifibss->basic_rates = ieee80211_mandatory_rates(local,
>> +					local->hw.conf.channel->band);
>>      
> Shouldn't cfg80211 do this?
>
> johannes
>    
Hi Johannes ,

                       Thank you for your suggestion,just found out ,i 
think  its already there to configure basic rates (if the user had not 
expicitly specified the basic rates in user space) in the 
nl80211_join_ibss(nl80211.c) , but the basic rates does not seems to get 
set there.I had checked its status in mac80211 in function 
ieee80211_ibss_join function , its still zero and I thought of calling 
it there itself , but the basic rate was not properly set for 2Ghz, so 
called it here and  I had tested it ,and everything working fine.
Pleas correct me if I am wrong .

with thanks,

shafi