From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Allow scanning single channel if other VIF is associated.
Date: Tue, 28 Sep 2010 06:50:28 -0700 [thread overview]
Message-ID: <4CA1F2A4.2090005@candelatech.com> (raw)
In-Reply-To: <1285658564.3885.1.camel@jlt3.sipsolutions.net>
On 09/28/2010 12:22 AM, Johannes Berg wrote:
> On Mon, 2010-09-27 at 17:07 -0700, greearb@candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> This patch aims to decrease channel switching when there is at least one
>> interface associated. This should help multiple station interfaces co-exist
>> on the same hardware, especially in WPA mode.
>
> Totally NACK. The code is ugly, complex, and unnecessary.
>
> You can make wpa_s scan the channels one by one, or you can improve the
> off-channel behaviour, but this is a workaround that just isn't
> appropriate.
At best, it would be a race for wpa_s to determine if any other interface
on it's interface's hardware is associated, so I don't see a good way to
do this in user-space.
When at least one is associated, I don't want the NIC to go offchannel at all,
at least not for wpa_s scanning. Anything else is going to interrupt other
stations's traffic, and for no good reason that I can see, since the scanning
interface must associate on the same channel as the rest of the stations
anyway.
If you have any suggestions for how to accomplish this, please let me know..
otherwise, I can just carry this patch in my tree.
Thanks,
Ben
>
> johannes
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-09-28 13:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 0:07 [PATCH 1/2] ath9k: Check for identical channels when changing channels greearb
2010-09-28 0:07 ` [PATCH 2/2] mac80211: Allow scanning single channel if other VIF is associated greearb
2010-09-28 7:22 ` Johannes Berg
2010-09-28 13:50 ` Ben Greear [this message]
2010-09-28 13:57 ` Johannes Berg
2010-09-28 15:17 ` Ben Greear
2010-09-28 15:18 ` Johannes Berg
2010-09-29 5:48 ` Jouni Malinen
2010-09-29 15:27 ` Ben Greear
2010-09-28 8:51 ` [PATCH 1/2] ath9k: Check for identical channels when changing channels Felix Fietkau
2010-09-28 13:37 ` Ben Greear
2010-09-28 14:05 ` Felix Fietkau
2010-09-28 15:22 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA1F2A4.2090005@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).