Re: [PATCH v3] mac80211: Allow scanning single channel if other VIF is associated.

[Ben Greear <greearb@candelatech.com>]

On 09/29/2010 09:48 AM, Johannes Berg wrote:

>> +			       !local->scan_channel))) {
>> +				/* Only change channels if we need to */
>> +				ieee80211_offchannel_stop_beaconing(local);
>> +				ieee80211_offchannel_stop_station(local);
>> +
>> +				local->tmp_channel = wk->chan;
>> +				local->tmp_channel_type = wk->chan_type;
>> +				ieee80211_hw_config(local, 0);
>> +			}
>>    			started = true;
>>    			wk->timeout = jiffies;
>
> Also, I believe it needs matching code to not do all the return stuff
> since we never left the channel, and I think it still needs to set
> tmp_channel so that nothing will switch away underneath or so... not
> quite sure.

Doesn't the remain_off_channel logic later in that method
take care of not calling the return to channel logic?
(Assuming I set the tmp_channel and tmp_channel_type as you suggest)?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com