Re: [RFC 2/2] wireless: Report noise to /proc/net/wireless

[Ben Greear <greearb@candelatech.com>]

On 09/30/2010 12:45 AM, Johannes Berg wrote:
> On Wed, 2010-09-29 at 16:57 -0700, greearb@candelatech.com wrote:
>
>> This adds noise reports to /proc/net/wireless again.
>
> Same comment applies here really...
>
>> + * @noise: noise, as obtained from dump_survey of index 0.
>
> It's not actually obtained that way, because if it was, cfg80211 could
> just handle it by itself.
>
> Additionally, even within mac80211 there's no guarantee that the
> dump_survey(0) callback will give you the correct channel's noise.
>
> Since you can easily obtain this information from userspace (and with
> the extension that Felix proposed you can figure out which noise belongs
> to the operating channel without really knowing the operating channel),
> I don't think we should be doing this.

Do you have a pointer to Felix's proposal?  Maybe I can use whatever API
he came up with to populate /proc/net/wireless with the noise from the current
channel.

Thanks,
Ben

>
> johannes


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com