From: Felix Fietkau <nbd@openwrt.org>
To: Rajkumar Manoharan <rmanoharan@atheros.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>
Subject: Re: [PATCH 3/4] ath9k_hw: clean up register write buffering
Date: Mon, 04 Oct 2010 13:53:33 +0200 [thread overview]
Message-ID: <4CA9C03D.9010503@openwrt.org> (raw)
In-Reply-To: <20101004085608.GA5931@vmraj-lnx.users.atheros.com>
On 2010-10-04 10:56 AM, Rajkumar Manoharan wrote:
> On Sun, Oct 03, 2010 at 10:37:18PM +0530, Felix Fietkau wrote:
>> static void ath9k_regwrite_flush(void *hw_priv)
>> {
>> struct ath_hw *ah = (struct ath_hw *) hw_priv;
>> @@ -397,6 +388,9 @@ static void ath9k_regwrite_flush(void *hw_priv)
>> u32 rsp_status;
>> int r;
>>
>> + if (!atomic_dec_and_test(&priv->wmi->mwrite_cnt))
>> + return;
>> +
> FMU, Assume that mwrite_cnt > 1 and a reg_read happens after a flush whose value
> depends on issued reg_write, the above check skips reg_write.
> The buffered commands only issued either mwrite_cnt reaches zero or
> buffer reaches MAX limit.
OK, makes sense, I'll resend.
- Felix
next prev parent reply other threads:[~2010-10-04 11:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-03 17:07 [PATCH 1/4] ath9k_hw: clean up calibration flags Felix Fietkau
2010-10-03 17:07 ` [PATCH 2/4] ath9k_hw: merge codepaths that access the cycle counter registers Felix Fietkau
2010-10-03 17:07 ` [PATCH 3/4] ath9k_hw: clean up register write buffering Felix Fietkau
2010-10-03 17:07 ` [PATCH 4/4] ath9k_hw: fix regression in ANI listen time calculation Felix Fietkau
2010-10-03 17:24 ` Luis R. Rodriguez
2010-10-03 19:08 ` Felix Fietkau
2010-10-03 19:10 ` Felix Fietkau
2010-10-04 8:56 ` [PATCH 3/4] ath9k_hw: clean up register write buffering Rajkumar Manoharan
2010-10-04 11:53 ` Felix Fietkau [this message]
2010-10-04 17:22 ` [PATCH v2 " Felix Fietkau
2010-10-05 4:38 ` Senthil Balasubramanian
2010-10-05 10:03 ` [PATCH v3 " Felix Fietkau
2010-10-06 20:32 ` John W. Linville
2010-10-04 6:34 ` [PATCH 2/4] ath9k_hw: merge codepaths that access the cycle counter registers Vasanthakumar Thiagarajan
2010-10-04 8:17 ` Adrian Chadd
2010-10-04 11:36 ` Felix Fietkau
2010-10-04 12:24 ` Vasanthakumar Thiagarajan
2010-10-04 12:51 ` Felix Fietkau
2010-10-05 9:59 ` Bruno Randolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA9C03D.9010503@openwrt.org \
--to=nbd@openwrt.org \
--cc=Luis.Rodriguez@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).