From: Felix Fietkau <nbd@openwrt.org>
To: "Björn Smedman" <bjorn.smedman@venatech.se>
Cc: linville@tuxdriver.com, johannes@sipsolutions.net,
lrodriguez@atheros.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] mac80211: minstrel_ht A-MPDU fix
Date: Mon, 11 Oct 2010 00:54:45 +0200 [thread overview]
Message-ID: <4CB24435.2070201@openwrt.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1010102206580.31264@bigbill>
On 2010-10-10 10:14 PM, Björn Smedman wrote:
> This patch fixes two problems with the minstrel_ht rate control
> algorithms handling of A-MPDU frames:
>
> 1. The ampdu_len field of the tx status is not always initialized for
> non-HT frames (and it would probably be unreasonable to require all
> drivers to do so). This could cause rate control statistics to be
> corrupted. We now trust the ampdu_len and ampdu_ack_len fields only when
> the frame is marked with the IEEE80211_TX_STAT_AMPDU flag.
>
> 2. Successful transmission attempts where only recognized when the A-MPDU
> subframe carrying the rate control status information was marked with the
> IEEE80211_TX_STAT_ACK flag. If this information happed to be carried on a
> frame that failed to be ACKed then the other subframes (which may have
> succeeded) where not correctly registered. We now update rate control
> statistics regardless of whether the subframe carrying the information was
> ACKed or not.
>
> Cc: <stable@kernel.org>
> Signed-off-by: Björn Smedman <bjorn.smedman@venatech.se>
For all 3 patches:
Acked-by: Felix Fietkau <nbd@openwrt.org>
prev parent reply other threads:[~2010-10-10 22:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 20:14 [PATCH 1/3] mac80211: minstrel_ht A-MPDU fix Björn Smedman
2010-10-10 22:54 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB24435.2070201@openwrt.org \
--to=nbd@openwrt.org \
--cc=bjorn.smedman@venatech.se \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).