linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] compat: fix a crash in the netlink backport
@ 2010-10-11 11:46 Felix Fietkau
  2010-10-11 17:42 ` Luis R. Rodriguez
  0 siblings, 1 reply; 2+ messages in thread
From: Felix Fietkau @ 2010-10-11 11:46 UTC (permalink / raw)
  To: linux-wireless; +Cc: Luis R. Rodriguez

Do not set the .doit wrapper if there is no .doit function.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
--- a/compat/compat-2.6.37.c
+++ b/compat/compat-2.6.37.c
@@ -130,7 +130,8 @@ int compat_genl_register_family_with_ops
 		__copy(dumpit);
 		__copy(done);
 #undef __copy
-		ops[i].ops.doit = nl_doit_wrapper;
+		if (ops[i].doit)
+			ops[i].ops.doit = nl_doit_wrapper;
 		ret = genl_register_ops(&family->family, &ops[i].ops);
 		if (ret < 0)
 			goto error_ops;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] compat: fix a crash in the netlink backport
  2010-10-11 11:46 [PATCH] compat: fix a crash in the netlink backport Felix Fietkau
@ 2010-10-11 17:42 ` Luis R. Rodriguez
  0 siblings, 0 replies; 2+ messages in thread
From: Luis R. Rodriguez @ 2010-10-11 17:42 UTC (permalink / raw)
  To: Felix Fietkau; +Cc: linux-wireless

On Mon, Oct 11, 2010 at 4:46 AM, Felix Fietkau <nbd@openwrt.org> wrote:
> Do not set the .doit wrapper if there is no .doit function.
>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>

Thanks, applied.

  Luis

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-10-11 17:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-11 11:46 [PATCH] compat: fix a crash in the netlink backport Felix Fietkau
2010-10-11 17:42 ` Luis R. Rodriguez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).