Re: [PATCH] wireless: Print wiphy name in sysfs.

[Ben Greear <greearb@candelatech.com>]

On 10/11/2010 11:42 AM, Johannes Berg wrote:
> On Mon, 2010-10-11 at 11:22 -0700, Ben Greear wrote:
>
>>> basename $(readlink /sys/class/net/wlan0/phy80211)
>>
>> It looks like that could work, but it seems a lot easier to probe
>> network devices via normal manner, and then check if I can just
>> open and read /sys/class/net/[dev-name]/phy80211/name
>>
>> I can do that easily from within a C/C++ program, where as
>> doing system calls and grabbing standard output is more of
>> a pain (and more overhead).
>>
>> But, if you don't want to add my patch, it's not a big deal.
>
> I don't really mind, it just didn't seem necessary. FWIW, readlink(2) is
> also a system call that your C program could use, but if you want the
> patch instead I guess that's fine.

I think it offers a bit of use at a small cost, but certainly
it's not a critical improvement.

If the maintainer picks it up, I'll happily use it..if not,
I can carry it in my own tree or use readdir or something.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com