From: Ben Greear <greearb@candelatech.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-wireless@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath5k: fix build break from "ath5k: Print out opmode in debugfs"
Date: Tue, 12 Oct 2010 16:31:32 -0700 [thread overview]
Message-ID: <4CB4EFD4.6020209@candelatech.com> (raw)
In-Reply-To: <20101012181804.GC2403@tuxdriver.com>
On 10/12/2010 11:18 AM, John W. Linville wrote:
> On Tue, Oct 12, 2010 at 11:13:31AM -0700, Linus Torvalds wrote:
>> On Tue, Oct 12, 2010 at 7:53 AM, John W. Linville
>> <linville@tuxdriver.com> wrote:
>>>
>>> Please don't make me commit such an ugly patch...
>>
>> Why don't you just create a dummy inline ath_opmode_to_string() that
>> returns NULL in the non-debug case? The compiler will make the
>> conditionals all go away, and it will end up being "UNKNOWN" which is
>> just what you want. No?
>
> Shhh! Your messing-up my manipulative mind games! :-)
Looks like this was my bug, and I lost these emails in a folder
I don't read so often.
If you're not happy with the fixes posted, let me know and
I'll work on one.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2010-10-12 23:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101012163519.a88f2040.sfr@canb.auug.org.au>
2010-10-12 14:53 ` [PATCH] ath5k: fix build break from "ath5k: Print out opmode in debugfs" John W. Linville
2010-10-12 15:43 ` Joe Perches
2010-10-12 17:15 ` John W. Linville
2010-10-12 16:54 ` Bob Copeland
2010-10-12 17:42 ` Bob Copeland
2010-10-12 18:07 ` Joe Perches
2010-10-12 18:13 ` Linus Torvalds
2010-10-12 18:18 ` John W. Linville
2010-10-12 23:31 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB4EFD4.6020209@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).