From: Tejun Heo <tj@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Linux Wireless List <linux-wireless@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2.6.36-rc7] mac80211: cancel restart_work explicitly instead of depending on flush_scheduled_work()
Date: Fri, 15 Oct 2010 18:39:37 +0200 [thread overview]
Message-ID: <4CB883C9.6050104@kernel.org> (raw)
In-Reply-To: <1287159715.1870.11.camel@Nokia-N900-51-1>
Hello,
On 10/15/2010 06:21 PM, Johannes Berg wrote:
>> - create_singlethread_workqueue(wiphy_name(local->hw.wiphy));
>> + alloc_ordered_workqueue(wiphy_name(local->hw.wiphy), 0);
>
> no description for this change?
Oops, right. create_*workqueue() interfaces are being replaced by
alloc_*workqueue(). It's part of the workqueue interface update.
>> - /*
>> - * For key todo, it'll be empty by now but the work
>> - * might still be scheduled.
>> - */
>> - flush_scheduled_work();
>
> oops, todo work no longer exists...
>
> Anyway, ACK.
Are you going to route this through wireless tree? Shall I repost
with update patch description?
Thank you.
--
tejun
next prev parent reply other threads:[~2010-10-15 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 15:35 [PATCH v2.6.36-rc7] mac80211: cancel restart_work explicitly instead of depending on flush_scheduled_work() Tejun Heo
2010-10-15 16:21 ` Johannes Berg
2010-10-15 16:39 ` Tejun Heo [this message]
2010-10-15 16:58 ` Christian Lamparter
2010-10-15 19:26 ` John W. Linville
2010-10-15 19:33 ` Tejun Heo
2010-10-15 20:07 ` Christian Lamparter
2010-10-15 20:06 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB883C9.6050104@kernel.org \
--to=tj@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).