* [RFC] ath9k: Fix incorrect access of rate flags in RC
@ 2010-10-25 15:36 Mohammed Shafi Shajakhan
2010-10-25 16:36 ` Luis R. Rodriguez
0 siblings, 1 reply; 5+ messages in thread
From: Mohammed Shafi Shajakhan @ 2010-10-25 15:36 UTC (permalink / raw)
To: linville
Cc: linux-wireless, lrodriguez, j, Senthilkumar.Balasubramanian,
Vasanth.Thiagarajan, nbd, Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
The index variable to access the rate flags should be obtained from the
inner loop counter which corresponds to rate table structure.
Signed-off-by: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
---
drivers/net/wireless/ath/ath9k/rc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
index 0cee90c..89978d7 100644
--- a/drivers/net/wireless/ath/ath9k/rc.c
+++ b/drivers/net/wireless/ath/ath9k/rc.c
@@ -527,7 +527,7 @@ static u8 ath_rc_setvalid_rates(struct ath_rate_priv *ath_rc_priv,
for (i = 0; i < rateset->rs_nrates; i++) {
for (j = 0; j < rate_table->rate_cnt; j++) {
u32 phy = rate_table->info[j].phy;
- u16 rate_flags = rate_table->info[i].rate_flags;
+ u16 rate_flags = rate_table->info[j].rate_flags;
u8 rate = rateset->rs_rates[i];
u8 dot11rate = rate_table->info[j].dot11rate;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RFC] ath9k: Fix incorrect access of rate flags in RC
2010-10-25 15:36 [RFC] ath9k: Fix incorrect access of rate flags in RC Mohammed Shafi Shajakhan
@ 2010-10-25 16:36 ` Luis R. Rodriguez
2010-10-26 4:42 ` Mohammed Shafi
0 siblings, 1 reply; 5+ messages in thread
From: Luis R. Rodriguez @ 2010-10-25 16:36 UTC (permalink / raw)
To: Mohammed Shafi Shajakhan
Cc: linville, linux-wireless, j, Senthilkumar.Balasubramanian,
Vasanth.Thiagarajan, nbd
On Mon, Oct 25, 2010 at 8:36 AM, Mohammed Shafi Shajakhan
<mshajakhan@atheros.com> wrote:
> From: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
>
> The index variable to access the rate flags should be obtained from the
> inner loop counter which corresponds to rate table structure.
>
> Signed-off-by: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
Is this a stable fix?
Luis
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC] ath9k: Fix incorrect access of rate flags in RC
2010-10-25 16:36 ` Luis R. Rodriguez
@ 2010-10-26 4:42 ` Mohammed Shafi
2010-10-28 12:15 ` Rajkumar Manoharan
0 siblings, 1 reply; 5+ messages in thread
From: Mohammed Shafi @ 2010-10-26 4:42 UTC (permalink / raw)
To: Luis R. Rodriguez
Cc: linux-wireless@vger.kernel.org, Senthilkumar Balasubramanian
looks like ,but not very sure Luis,need to consult Senthil and will tell
you.
thanks,
shafi
On Monday 25 October 2010 10:06 PM, Luis R. Rodriguez wrote:
> On Mon, Oct 25, 2010 at 8:36 AM, Mohammed Shafi Shajakhan
> <mshajakhan@atheros.com> wrote:
>
>> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>
>> The index variable to access the rate flags should be obtained from the
>> inner loop counter which corresponds to rate table structure.
>>
>> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>
> Is this a stable fix?
>
> Luis
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [RFC] ath9k: Fix incorrect access of rate flags in RC
2010-10-26 4:42 ` Mohammed Shafi
@ 2010-10-28 12:15 ` Rajkumar Manoharan
2010-10-28 12:33 ` Mohammed Shafi
0 siblings, 1 reply; 5+ messages in thread
From: Rajkumar Manoharan @ 2010-10-28 12:15 UTC (permalink / raw)
To: mshajakhan, lrodriguez; +Cc: linux-wireless, senthilkumar.balasubramanian
> looks like ,but not very sure Luis,need to consult Senthil and will tell
> you.
> thanks,
> shafi
>
> On Monday 25 October 2010 10:06 PM, Luis R. Rodriguez wrote:
> > On Mon, Oct 25, 2010 at 8:36 AM, Mohammed Shafi Shajakhan
> > wrote:
> >
> >> From: Mohammed Shafi Shajakhan
> >>
> >> The index variable to access the rate flags should be obtained from the
> >> inner loop counter which corresponds to rate table structure.
> >>
> >> Signed-off-by: Mohammed Shafi Shajakhan
> >>
> > Is this a stable fix?
> >
> > Luis
> >
Yes it is a stable fix. It solves the invalid rate selection when the supported basic rate
is invalid on a purticular band. This patch fixed the following warning message.
Call Trace:
[<ffffffff8104ee4a>] warn_slowpath_common+0x7a/0xb0
[<ffffffff8104ee95>] warn_slowpath_null+0x15/0x20
[<ffffffffa0583c45>] ath_get_rate+0x595/0x5b0 [ath9k]
[<ffffffff811a0636>] ? cpumask_next_and+0x36/0x50
[<ffffffffa0405186>] rate_control_get_rate+0x86/0x160 [mac80211]
[<ffffffffa040dfac>] invoke_tx_handlers+0x81c/0x12d0 [mac80211]
[<ffffffffa040eae9>] ieee80211_tx+0x89/0x2b0 [mac80211]
[<ffffffff812891bc>] ? pskb_expand_head+0x1cc/0x1f0
[<ffffffffa040edc5>] ieee80211_xmit+0xb5/0x1c0 [mac80211]
[<ffffffffa041026f>] ieee80211_tx_skb+0x4f/0x60 [mac80211]
[<ffffffffa03fe016>] ieee80211_send_nullfunc+0x46/0x60 [mac80211]
[<ffffffffa03f91d7>] ieee80211_offchannel_stop_station+0x107/0x150 [mac80211]
[<ffffffff812891bc>] ? pskb_expand_head+0x1cc/0x1f0
[<ffffffffa040edc5>] ieee80211_xmit+0xb5/0x1c0 [mac80211]
[<ffffffffa041026f>] ieee80211_tx_skb+0x4f/0x60 [mac80211]
[<ffffffffa03fe016>] ieee80211_send_nullfunc+0x46/0x60 [mac80211]
[<ffffffffa03f91d7>] ieee80211_offchannel_stop_station+0x107/0x150 [mac80211]
[<ffffffffa03f8896>] ieee80211_scan_work+0x146/0x600 [mac80211]
[<ffffffff8133a375>] ? schedule+0x2f5/0x8e0
[<ffffffffa03f8750>] ? ieee80211_scan_work+0x0/0x600 [mac80211]
[<ffffffff81064fcf>] process_one_work+0x10f/0x380
[<ffffffff81066bc2>] worker_thread+0x162/0x340
[<ffffffff81066a60>] ? worker_thread+0x0/0x340
- Rajkumar
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC] ath9k: Fix incorrect access of rate flags in RC
2010-10-28 12:15 ` Rajkumar Manoharan
@ 2010-10-28 12:33 ` Mohammed Shafi
0 siblings, 0 replies; 5+ messages in thread
From: Mohammed Shafi @ 2010-10-28 12:33 UTC (permalink / raw)
To: Rajkumar Manoharan; +Cc: linux-wireless@vger.kernel.org
On Thursday 28 October 2010 05:45 PM, Rajkumar Manoharan wrote:
>
>> looks like ,but not very sure Luis,need to consult Senthil and will tell
>> you.
>> thanks,
>> shafi
>>
>> On Monday 25 October 2010 10:06 PM, Luis R. Rodriguez wrote:
>>
>>> On Mon, Oct 25, 2010 at 8:36 AM, Mohammed Shafi Shajakhan
>>> wrote:
>>>
>>>
>>>> From: Mohammed Shafi Shajakhan
>>>>
>>>> The index variable to access the rate flags should be obtained from the
>>>> inner loop counter which corresponds to rate table structure.
>>>>
>>>> Signed-off-by: Mohammed Shafi Shajakhan
>>>>
>>>>
>>> Is this a stable fix?
>>>
>>> Luis
>>>
>>>
> Yes it is a stable fix. It solves the invalid rate selection when the supported basic rate
>
> is invalid on a purticular band. This patch fixed the following warning message.
>
>
>
> Call Trace:
>
> [<ffffffff8104ee4a>] warn_slowpath_common+0x7a/0xb0
>
> [<ffffffff8104ee95>] warn_slowpath_null+0x15/0x20
>
> [<ffffffffa0583c45>] ath_get_rate+0x595/0x5b0 [ath9k]
>
> [<ffffffff811a0636>] ? cpumask_next_and+0x36/0x50
>
> [<ffffffffa0405186>] rate_control_get_rate+0x86/0x160 [mac80211]
>
> [<ffffffffa040dfac>] invoke_tx_handlers+0x81c/0x12d0 [mac80211]
>
> [<ffffffffa040eae9>] ieee80211_tx+0x89/0x2b0 [mac80211]
>
> [<ffffffff812891bc>] ? pskb_expand_head+0x1cc/0x1f0
>
> [<ffffffffa040edc5>] ieee80211_xmit+0xb5/0x1c0 [mac80211]
>
> [<ffffffffa041026f>] ieee80211_tx_skb+0x4f/0x60 [mac80211]
>
> [<ffffffffa03fe016>] ieee80211_send_nullfunc+0x46/0x60 [mac80211]
>
> [<ffffffffa03f91d7>] ieee80211_offchannel_stop_station+0x107/0x150 [mac80211]
>
> [<ffffffff812891bc>] ? pskb_expand_head+0x1cc/0x1f0
>
> [<ffffffffa040edc5>] ieee80211_xmit+0xb5/0x1c0 [mac80211]
>
> [<ffffffffa041026f>] ieee80211_tx_skb+0x4f/0x60 [mac80211]
>
> [<ffffffffa03fe016>] ieee80211_send_nullfunc+0x46/0x60 [mac80211]
>
> [<ffffffffa03f91d7>] ieee80211_offchannel_stop_station+0x107/0x150 [mac80211]
>
> [<ffffffffa03f8896>] ieee80211_scan_work+0x146/0x600 [mac80211]
>
> [<ffffffff8133a375>] ? schedule+0x2f5/0x8e0
>
> [<ffffffffa03f8750>] ? ieee80211_scan_work+0x0/0x600 [mac80211]
>
> [<ffffffff81064fcf>] process_one_work+0x10f/0x380
>
> [<ffffffff81066bc2>] worker_thread+0x162/0x340
>
> [<ffffffff81066a60>] ? worker_thread+0x0/0x340
>
> - Rajkumar
> .
>
>
Thanks Raj.
shafi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-10-28 12:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-25 15:36 [RFC] ath9k: Fix incorrect access of rate flags in RC Mohammed Shafi Shajakhan
2010-10-25 16:36 ` Luis R. Rodriguez
2010-10-26 4:42 ` Mohammed Shafi
2010-10-28 12:15 ` Rajkumar Manoharan
2010-10-28 12:33 ` Mohammed Shafi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).