From: Shahar Levi <shahar_levi@ti.com>
To: Luciano Coelho <luciano.coelho@nokia.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH ] wl1271: Change wl12xx Files Names
Date: Thu, 28 Oct 2010 19:53:26 +0200 [thread overview]
Message-ID: <4CC9B896.4010507@ti.com> (raw)
In-Reply-To: <1288288436.3414.10.camel@powerslave>
On 10/28/2010 07:53 PM, Luciano Coelho wrote:
> On Thu, 2010-10-28 at 19:01 +0200, ext Shahar Levi wrote:
>> On 10/28/2010 07:01 PM, Luciano Coelho wrote:
>>> On Thu, 2010-10-28 at 18:16 +0200, ext Shahar Levi wrote:
>>>> On 10/27/2010 09:25 PM, Luciano Coelho wrote:
>>>>> On Tue, 2010-10-26 at 13:18 +0200, ext Shahar Levi wrote:
>>>>>> +wl12xx_spi-objs = spi.o
>>>>>> +wl12xx_sdio-objs = sdio.o
>>>>>
>>>>> Here...
>>>> Will be fix in v2
>>>
>>> There's nothing to fix here. I just pointed out that the modules are
>>> actually called wl12xx_sdio and wl12xx_spi. So it's correct here
>>> already.
>> Due to the fact it is confusing spi and sdio i renamed spi.c file name
>> to wl12xx_spi.c (in v2) and in that case i remove those lines.
>> The same catch for sdio.c
>
> Sorry, I don't get the reasoning behind this. sdio.c and spi.c are
> better than wl12xx_sdio.c and wl12xx_spi.c. Why not keep things
> consistent all across?
OK, revert to spi and sdio.
>>>>>> diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/main.c
>>>>>> similarity index 99%
>>>>>> rename from drivers/net/wireless/wl12xx/wl1271_main.c
>>>>>> rename to drivers/net/wireless/wl12xx/main.c
>>>>>> index 63036b5..dab10a5 100644
>>>>>> --- a/drivers/net/wireless/wl12xx/wl1271_main.c
>>>>>> +++ b/drivers/net/wireless/wl12xx/main.c
>>>>>> @@ -31,20 +31,20 @@
>>>>>
>>>>> [...]
>>>>>
>>>>>> #define WL1271_BOOT_RETRIES 3
>>>>>
>>>>> Did we agree not to change this stuff for now? Yes, now I remember, it's
>>>>> better to do it in two steps indeed (ie. do the other changes in a
>>>>> separate patch). But I'd rather apply all the patches add once.
>>>> I believe that patch could stand alone. There isn't any connection
>>>> between files names and function+defines names.
>>>
>>> Yes, no need to change these macros or function names in this patch.
>> In that case it can be apply alon, is it? ;-)
>
> Not sure I understand this. We should have two separate patches, one
> with the file name changes (including the #define __CONF_H__ stuff) and
> another patch just to change the function names and macros.
OK
prev parent reply other threads:[~2010-10-28 17:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 11:18 [PATCH ] wl1271: Change wl12xx Files Names Shahar Levi
2010-10-27 19:25 ` Luciano Coelho
2010-10-28 16:16 ` Shahar Levi
2010-10-28 17:01 ` Luciano Coelho
2010-10-28 17:01 ` Shahar Levi
2010-10-28 17:53 ` Luciano Coelho
2010-10-28 17:53 ` Shahar Levi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC9B896.4010507@ti.com \
--to=shahar_levi@ti.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).