From: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: htl10@users.sourceforge.net, linux-wireless@vger.kernel.org,
John W Linville <linville@tuxdriver.com>
Subject: Re: [PATCH 3/9] rtl8187: fix wrong register initialization in 8187B
Date: Tue, 02 Nov 2010 01:01:16 -0200 [thread overview]
Message-ID: <4CCF7EFC.1050000@mandriva.com.br> (raw)
In-Reply-To: <4CCF7B73.7040906@lwfinger.net>
On 02-11-2010 00:46, Larry Finger wrote:
> On 11/01/2010 09:42 PM, Hin-Tak Leung wrote:
>>
>> --- On Tue, 2/11/10, Herton Ronaldo Krzesinski<herton@mandriva.com.br> wrote:
>>
>>> We were using wrong address for BRSR
>>> (Basic Rate Set Register) while
>>> initializing its value, comparing with Realtek sources, for
>>> 8187B case.
>>>
>>> Also, the same register is initialized in
>>> rtl8187b_reg_table, so remove
>>> the duplicate initialization from the table.
>>>
>>> Signed-off-by: Herton Ronaldo Krzesinski<herton@mandriva.com.br>
>>> Acked-by: Larry Finger<Larry.Finger@lwfinger.net>
>>
>> Acked-by: Hin-Tak Leung<htl10@users.sourceforge.net>
>>
>> ANAPARAM* stands for "anonymous parameters", right? One of these days we should give them some meaningful names.
>
> I have always thought it was for "analog parameter". Am I wrong?
Nope, you're right, its listed description is "analog parameter" in 8180
spec.
>
> Larry
--
[]'s
Herton
next prev parent reply other threads:[~2010-11-02 3:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 0:59 [PATCH 0/9] rtl8187: start cleanup/revisiting code Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 1/9] rtl8187: remove redundant initialization of ARFR Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 2/9] rtl8187: remove setting of beacon/atim registers from initialization Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 3/9] rtl8187: fix wrong register initialization in 8187B Herton Ronaldo Krzesinski
2010-11-02 2:42 ` Hin-Tak Leung
2010-11-02 2:46 ` Larry Finger
2010-11-02 3:01 ` Herton Ronaldo Krzesinski [this message]
2010-11-02 23:48 ` Rogerio Luz Coelho
2010-11-02 23:57 ` Larry Finger
2010-11-03 0:01 ` Rogerio Luz Coelho
2010-11-03 0:45 ` Larry Finger
2010-11-03 1:06 ` Rogerio Luz Coelho
2010-11-03 1:44 ` Larry Finger
2010-11-04 14:06 ` Hin-Tak Leung
2010-11-04 14:15 ` Hin-Tak Leung
2010-11-05 20:30 ` Rogerio Luz Coelho
2010-11-03 13:28 ` Herton Ronaldo Krzesinski
2010-11-04 2:41 ` Rogerio Luz Coelho
2010-11-04 2:57 ` Larry Finger
2010-11-02 3:01 ` Hin-Tak Leung
2010-11-02 0:59 ` [PATCH 4/9] rtl8187: avoid redundant write to register FF72 (RFSW_CTRL) Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 5/9] rtl8187: move pll reset at start out of ANAPARAM write Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 6/9] rtl8187: don't set RTL818X_CONFIG3_GNT_SELECT flag on 8187B Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 7/9] rtl8187: consolidate anaparam on/off write sequences Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 8/9] rtl8187: remove uneeded setting of anaparam write Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 9/9] rtl8187: restore anaparam registers after reset with 8187B Herton Ronaldo Krzesinski
2010-11-04 15:30 ` Thadeu Lima de Souza Cascardo
2010-11-04 15:50 ` Herton Ronaldo Krzesinski
2010-11-05 19:45 ` Thadeu Lima de Souza Cascardo
2010-11-07 1:07 ` Herton Ronaldo Krzesinski
2010-11-07 1:29 ` Hin-Tak Leung
2010-11-07 3:28 ` Herton Ronaldo Krzesinski
2010-11-07 3:45 ` Larry Finger
2010-11-02 1:02 ` [PATCH 0/9] rtl8187: start cleanup/revisiting code Herton Ronaldo Krzesinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCF7EFC.1050000@mandriva.com.br \
--to=herton@mandriva.com.br \
--cc=Larry.Finger@lwfinger.net \
--cc=htl10@users.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).