From: Larry Finger <Larry.Finger@lwfinger.net>
To: Rogerio Luz Coelho <rogluz.news@gmail.com>
Cc: Herton Ronaldo Krzesinski <herton@mandriva.com.br>,
Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/9] rtl8187: fix wrong register initialization in 8187B
Date: Tue, 02 Nov 2010 19:45:32 -0500 [thread overview]
Message-ID: <4CD0B0AC.4050102@lwfinger.net> (raw)
In-Reply-To: <AANLkTin937V6hJ4L2o-SF5riTh0MpTd3e6faZnbZuV48@mail.gmail.com>
On 11/02/2010 07:01 PM, Rogerio Luz Coelho wrote:
No effect is better than "regression" right?
>
> I am not saying the chip got magically better, it still seems a cheap
> POS, but with Cascardo's patch is as good as the Win7 driver here.
If you apply Herton's series of 9 patches, you should see a throughput
improvement. On my card, I get full performance from the 54M rate (27 Mb/s),
whereas the best I could do before those patches was 11 Mb/s.
Incidentally, making the Realtek drivers work on x86_64 is not that difficult.
In any place that they cast a pointer as (u32), that gets changed to
(__kernel_size_t). The other place that is affected is due to changes in the skb
buffer parameters tail and data, which are pointers in 32-bit, and offsets in
64-bit systems. The main point is that you cannot ignore any gcc warnings.
Larry
next prev parent reply other threads:[~2010-11-03 0:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 0:59 [PATCH 0/9] rtl8187: start cleanup/revisiting code Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 1/9] rtl8187: remove redundant initialization of ARFR Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 2/9] rtl8187: remove setting of beacon/atim registers from initialization Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 3/9] rtl8187: fix wrong register initialization in 8187B Herton Ronaldo Krzesinski
2010-11-02 2:42 ` Hin-Tak Leung
2010-11-02 2:46 ` Larry Finger
2010-11-02 3:01 ` Herton Ronaldo Krzesinski
2010-11-02 23:48 ` Rogerio Luz Coelho
2010-11-02 23:57 ` Larry Finger
2010-11-03 0:01 ` Rogerio Luz Coelho
2010-11-03 0:45 ` Larry Finger [this message]
2010-11-03 1:06 ` Rogerio Luz Coelho
2010-11-03 1:44 ` Larry Finger
2010-11-04 14:06 ` Hin-Tak Leung
2010-11-04 14:15 ` Hin-Tak Leung
2010-11-05 20:30 ` Rogerio Luz Coelho
2010-11-03 13:28 ` Herton Ronaldo Krzesinski
2010-11-04 2:41 ` Rogerio Luz Coelho
2010-11-04 2:57 ` Larry Finger
2010-11-02 3:01 ` Hin-Tak Leung
2010-11-02 0:59 ` [PATCH 4/9] rtl8187: avoid redundant write to register FF72 (RFSW_CTRL) Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 5/9] rtl8187: move pll reset at start out of ANAPARAM write Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 6/9] rtl8187: don't set RTL818X_CONFIG3_GNT_SELECT flag on 8187B Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 7/9] rtl8187: consolidate anaparam on/off write sequences Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 8/9] rtl8187: remove uneeded setting of anaparam write Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 9/9] rtl8187: restore anaparam registers after reset with 8187B Herton Ronaldo Krzesinski
2010-11-04 15:30 ` Thadeu Lima de Souza Cascardo
2010-11-04 15:50 ` Herton Ronaldo Krzesinski
2010-11-05 19:45 ` Thadeu Lima de Souza Cascardo
2010-11-07 1:07 ` Herton Ronaldo Krzesinski
2010-11-07 1:29 ` Hin-Tak Leung
2010-11-07 3:28 ` Herton Ronaldo Krzesinski
2010-11-07 3:45 ` Larry Finger
2010-11-02 1:02 ` [PATCH 0/9] rtl8187: start cleanup/revisiting code Herton Ronaldo Krzesinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD0B0AC.4050102@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=cascardo@holoscopio.com \
--cc=herton@mandriva.com.br \
--cc=linux-wireless@vger.kernel.org \
--cc=rogluz.news@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).