From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Michael Büsch" <mb@bu3sch.de>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH] ssb: workarounds: be verbose about hacking SPROM revision, don't duplicate code
Date: Wed, 03 Nov 2010 16:52:29 -0500 [thread overview]
Message-ID: <4CD1D99D.5070501@lwfinger.net> (raw)
In-Reply-To: <1288820625.7368.117.camel@maggie>
On 11/03/2010 04:43 PM, Michael Büsch wrote:
> On Wed, 2010-11-03 at 22:06 +0100, Rafał Miłecki wrote:
>> + default:
>> + ssb_printk(KERN_WARNING PFX "Unsupported SPROM"
>> + " revision %d detected. Will extract"
>> + " v1\n", out->revision);
>> + out->revision = 1;
>> + sprom_extract_r123(out, in);
>
> I think we should change this to throw a hard error if the sprom is
> unknown. Extracting r123 is unlikely to do any good these days.
> This workaround was only useful back in the days where 95% of the
> cards out there were r123. But today that's not the case.
>
>> }
>>
>> if (out->boardflags_lo == 0xFFFF)
In any case, the out->revision = 1 statement should be before the ssb_printk() call.
I agree - throw a hard error.
Larry
next prev parent reply other threads:[~2010-11-03 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-03 21:06 [PATCH] ssb: workarounds: be verbose about hacking SPROM revision, don't duplicate code Rafał Miłecki
2010-11-03 21:43 ` Michael Büsch
2010-11-03 21:52 ` Larry Finger [this message]
2010-11-03 21:53 ` Michael Büsch
2010-11-03 21:59 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD1D99D.5070501@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).