From: Larry Finger <Larry.Finger@lwfinger.net>
To: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Cc: htl10@users.sourceforge.net,
Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
linux-wireless@vger.kernel.org,
John W Linville <linville@tuxdriver.com>,
seno <senada@t-online.de>
Subject: Re: [PATCH 9/9] rtl8187: restore anaparam registers after reset with 8187B
Date: Sat, 06 Nov 2010 22:45:11 -0500 [thread overview]
Message-ID: <4CD620C7.20308@lwfinger.net> (raw)
In-Reply-To: <20101107012832.6b2f874a@mandriva.com.br>
On 11/06/2010 10:28 PM, Herton Ronaldo Krzesinski wrote:
> Em Sun, 7 Nov 2010 01:29:30 +0000 (GMT)
> Hin-Tak Leung <htl10@users.sourceforge.net> escreveu:
>
>> --- On Sun, 7/11/10, Herton Ronaldo Krzesinski
>> <herton@mandriva.com.br> wrote:
>>
>> <snipped>
>>> It's strange that with or without the patch you get too low
>>> transfer
>>> values. In this case we should have another bug with your
>>> device. I don't
>>> know now what could be happening, but first thing that I
>>> thought is that
>>> this could be related to antenna selection (and I'm curious
>>> about analog
>>> parameters on the eeprom of device too). Please try
>>> following debug patch
>>> and post results (also post what type of RTL8187 the driver
>>> detects/prints
>>> on kernel log too, may help). And if is something related
>>> to antena selection,
>>> try change the if condition on the patch and see if that
>>> helps.
>> <snipped>
>>
>> That reminds me - I have an "antenna diversity" patch dated "April 9
>> 2009" on my desktop which I think I got off linux-wireless from
>> somebody with a dual-antenna device, derived from scavenging from the
>> vendor driver, I think, that we are supposed to do something about
>> but I certainly haven't done anything about it. Did either/any of you
>> look at that and/or remember having done anything about that patch?
>
> Do you have any pointer to it? (I can't find in the archives in April
> 9 2009). Never saw it, if was posted in the mailing list certainly
> missed it (and probably I was not in CC).
There is a reference to it at
http://www.spinics.net/lists/linux-wireless/msg31345.html. The patches were
never done quite right, and I do not remember testing. As I have only 1 antenna
(I think), it likely would not have affected the results.
Larry
next prev parent reply other threads:[~2010-11-07 3:44 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 0:59 [PATCH 0/9] rtl8187: start cleanup/revisiting code Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 1/9] rtl8187: remove redundant initialization of ARFR Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 2/9] rtl8187: remove setting of beacon/atim registers from initialization Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 3/9] rtl8187: fix wrong register initialization in 8187B Herton Ronaldo Krzesinski
2010-11-02 2:42 ` Hin-Tak Leung
2010-11-02 2:46 ` Larry Finger
2010-11-02 3:01 ` Herton Ronaldo Krzesinski
2010-11-02 23:48 ` Rogerio Luz Coelho
2010-11-02 23:57 ` Larry Finger
2010-11-03 0:01 ` Rogerio Luz Coelho
2010-11-03 0:45 ` Larry Finger
2010-11-03 1:06 ` Rogerio Luz Coelho
2010-11-03 1:44 ` Larry Finger
2010-11-04 14:06 ` Hin-Tak Leung
2010-11-04 14:15 ` Hin-Tak Leung
2010-11-05 20:30 ` Rogerio Luz Coelho
2010-11-03 13:28 ` Herton Ronaldo Krzesinski
2010-11-04 2:41 ` Rogerio Luz Coelho
2010-11-04 2:57 ` Larry Finger
2010-11-02 3:01 ` Hin-Tak Leung
2010-11-02 0:59 ` [PATCH 4/9] rtl8187: avoid redundant write to register FF72 (RFSW_CTRL) Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 5/9] rtl8187: move pll reset at start out of ANAPARAM write Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 6/9] rtl8187: don't set RTL818X_CONFIG3_GNT_SELECT flag on 8187B Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 7/9] rtl8187: consolidate anaparam on/off write sequences Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 8/9] rtl8187: remove uneeded setting of anaparam write Herton Ronaldo Krzesinski
2010-11-02 0:59 ` [PATCH 9/9] rtl8187: restore anaparam registers after reset with 8187B Herton Ronaldo Krzesinski
2010-11-04 15:30 ` Thadeu Lima de Souza Cascardo
2010-11-04 15:50 ` Herton Ronaldo Krzesinski
2010-11-05 19:45 ` Thadeu Lima de Souza Cascardo
2010-11-07 1:07 ` Herton Ronaldo Krzesinski
2010-11-07 1:29 ` Hin-Tak Leung
2010-11-07 3:28 ` Herton Ronaldo Krzesinski
2010-11-07 3:45 ` Larry Finger [this message]
2010-11-02 1:02 ` [PATCH 0/9] rtl8187: start cleanup/revisiting code Herton Ronaldo Krzesinski
-- strict thread matches above, loose matches on Subject: below --
2010-11-07 13:51 [PATCH 9/9] rtl8187: restore anaparam registers after reset with 8187B Hin-Tak Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD620C7.20308@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=cascardo@holoscopio.com \
--cc=herton@mandriva.com.br \
--cc=htl10@users.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=senada@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).