From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Tejun Heo <tj@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: ath5k/mac80211: Reproducible deadlock with 64-stations.
Date: Fri, 12 Nov 2010 08:32:57 -0800 [thread overview]
Message-ID: <4CDD6C39.9070400@candelatech.com> (raw)
In-Reply-To: <1289529427.3695.9.camel@jlt3.sipsolutions.net>
On 11/11/2010 06:37 PM, Johannes Berg wrote:
> On Thu, 2010-11-11 at 16:48 -0800, Ben Greear wrote:
>> I have a potential scenario:
>>
>> The ieee80211_do_stop logic is called under RTNL, and it
>> then calls flush_work().
>>
>> What if the worker thread is currently blocked on something like
>> wireless_nlevent_process which tries to acquire rtnl?
>>
>> Wouldn't that cause a deadlock?
>
> Only if Tejun's deadlock avoidance doesn't work -- we used to have a
> separate kernel thread for mac80211 work including sdata->work which
> never acquired the RTNL. Also, we have lockdep annotations for exactly
> this kind of thing ("events" and "(linkwatch_work).work" in your held
> locks output) that should catch this.
There is a warning early in the boot from lockdep, not related to wifi.
I fear that is disabling all further lockdep warnings.
Thanks,
Ben
>
> johannes
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-11-12 16:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 23:02 ath5k/mac80211: Reproducible deadlock with 64-stations Ben Greear
2010-11-11 0:57 ` Ben Greear
2010-11-11 1:03 ` Johannes Berg
2010-11-11 5:51 ` Ben Greear
2010-11-11 1:02 ` Johannes Berg
2010-11-11 9:27 ` Tejun Heo
2010-11-11 16:55 ` Ben Greear
2010-11-11 18:26 ` Ben Greear
2010-11-11 23:12 ` Ben Greear
2010-11-12 10:11 ` Tejun Heo
2010-11-12 10:15 ` Tejun Heo
2010-11-12 18:06 ` Ben Greear
2010-11-12 18:13 ` Tejun Heo
2010-11-12 18:34 ` Ben Greear
2010-11-12 17:18 ` Ben Greear
2010-11-12 0:48 ` Ben Greear
2010-11-12 2:37 ` Johannes Berg
2010-11-12 16:32 ` Ben Greear [this message]
2010-11-12 16:45 ` Johannes Berg
2010-11-12 17:37 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDD6C39.9070400@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).