From: Felix Fietkau <nbd@openwrt.org>
To: Bob Copeland <me@bobcopeland.com>
Cc: Wojciech Dubowik <dubowoj@neratec.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 8/9] ath5k: AHB port. Add AHB bus support.
Date: Fri, 12 Nov 2010 20:36:51 +0100 [thread overview]
Message-ID: <4CDD9753.80909@openwrt.org> (raw)
In-Reply-To: <AANLkTinoANxSOiBJpa2hDk7V=ScSa66rcj-f1HfQGV1u@mail.gmail.com>
On 2010-11-12 8:26 PM, Bob Copeland wrote:
> On Thu, Nov 11, 2010 at 9:58 AM, Wojciech Dubowik <dubowoj@neratec.com> wrote:
>>
>> AHB specific functions are now in ahb.c file. There is no common
>> init functions which tries first pci and then ahb becasue on some
>
> 'because'
>
>> --- a/drivers/net/wireless/ath/ath5k/Makefile
>> +++ b/drivers/net/wireless/ath/ath5k/Makefile
>> @@ -15,5 +15,5 @@ ath5k-y += rfkill.o
>> ath5k-y += ani.o
>> ath5k-y += sysfs.o
>> ath5k-$(CONFIG_ATH5K_DEBUG) += debug.o
>> -ath5k-y += pci.o
>> +ath5k-y += $(if $(CONFIG_ATHEROS_AR231X),ahb,pci).o
>> obj-$(CONFIG_ATH5K) += ath5k.o
>
> This is not the right way.. what if someone wants both in one kernel?
Having both in the kernel is completely pointless. There are no devices
that can support both, nor will there ever be.
- Felix
next prev parent reply other threads:[~2010-11-12 19:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <22942120.791289486697022.JavaMail.wlan@CHBU500181>
2010-11-11 14:58 ` [PATCH 8/9] ath5k: AHB port. Add AHB bus support Wojciech Dubowik
2010-11-12 19:26 ` Bob Copeland
2010-11-12 19:36 ` Felix Fietkau [this message]
2010-11-12 19:51 ` Wojciech Dubowik
2010-11-12 19:55 ` Felix Fietkau
2010-11-13 13:27 ` Bob Copeland
[not found] <16168765.161289826231239.JavaMail.wlan@CHBU500181>
2010-11-15 13:16 ` Wojciech Dubowik
2010-11-15 15:07 ` Bob Copeland
[not found] <25235417.301289836112686.JavaMail.wlan@CHBU500181>
2010-11-15 15:49 ` Wojciech Dubowik
2010-11-15 16:37 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDD9753.80909@openwrt.org \
--to=nbd@openwrt.org \
--cc=dubowoj@neratec.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).