From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH 1/4] b43: N-PHY: fix values for PHY regs in channel tables of 2055 radio
Date: Thu, 18 Nov 2010 09:53:06 -0600 [thread overview]
Message-ID: <4CE54BE2.2070302@lwfinger.net> (raw)
In-Reply-To: <1290083280-13550-1-git-send-email-zajec5@gmail.com>
On 11/18/2010 06:27 AM, Rafał Miłecki wrote:
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
This change deserves a bit more explanation. You might include something like
"These tables came from reverse engineering the 5.10.56.46 version of the
Broadcom driver. Trace comparisons between b43 and the current Broadcom driver
(5.10.120.0) show byte reversals for the PHY register writes."
Larry
> drivers/net/wireless/b43/radio_2055.c | 248 ++++++++++++++++----------------
> 1 files changed, 124 insertions(+), 124 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/radio_2055.c b/drivers/net/wireless/b43/radio_2055.c
> index 0d67715..10910dc 100644
> --- a/drivers/net/wireless/b43/radio_2055.c
> +++ b/drivers/net/wireless/b43/radio_2055.c
> @@ -307,7 +307,7 @@ static const struct b43_nphy_channeltab_entry_rev2 b43_nphy_channeltab_rev2[] =
> RADIOREGS(0x71, 0x01, 0xEC, 0x0F, 0xFF, 0x01, 0x04, 0x0A,
> 0x00, 0x8F, 0xFF, 0xFF, 0xFF, 0x00, 0x0F, 0x0F,
> 0x8F, 0xFF, 0x00, 0x0F, 0x0F, 0x8F),
> - PHYREGS(0xB407, 0xB007, 0xAC07, 0x1402, 0x1502, 0x1602),
> + PHYREGS(0x07B4, 0x07B0, 0x07AC, 0x0214, 0x0215, 0x0216),
> },
next prev parent reply other threads:[~2010-11-18 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 12:27 [PATCH 1/4] b43: N-PHY: fix values for PHY regs in channel tables of 2055 radio Rafał Miłecki
2010-11-18 12:27 ` [PATCH 2/4] b43: N-PHY: minor fixes to match specs Rafał Miłecki
2010-11-18 12:27 ` [PATCH 3/4] b43: N-PHY: fix some typos, conditions, set gain_boost Rafał Miłecki
2010-11-18 12:28 ` [PATCH 4/4] b43: N-PHY: init BPHY when needed Rafał Miłecki
2010-11-18 15:53 ` Larry Finger [this message]
2010-11-18 16:34 ` [PATCH 1/4] b43: N-PHY: fix values for PHY regs in channel tables of 2055 radio Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE54BE2.2070302@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).