From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Ivo van Doorn <IvDoorn@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 60/62] rt2x00: Use static const
Date: Sun, 21 Nov 2010 09:58:55 +0100 [thread overview]
Message-ID: <4CE8DF4F.5050803@gmail.com> (raw)
In-Reply-To: <d8bfaded20da2265673391a81536d63b0e81dc7f.1290305776.git.joe@perches.com>
On 11/21/10 03:39, Joe Perches wrote:
> Using static const generally increases object text and decreases data size.
> It also generally decreases overall object size.
>
> text data bss dec hex filename
> 40197 56 8336 48589 bdcd drivers/net/wireless/rt2x00/rt2800lib.o.new
> 40205 56 8336 48597 bdd5 drivers/net/wireless/rt2x00/rt2800lib.o.old
>
> Signed-off-by: Joe Perches <joe@perches.com>
For rt2x00 this is just a tiny optimization, but for what it's worth:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index ce8df66..7563161 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -2166,7 +2166,7 @@ static int rt2800_init_registers(struct rt2x00_dev *rt2x00dev)
> SHARED_KEY_MODE_ENTRY(i), 0);
>
> for (i = 0; i < 256; i++) {
> - u32 wcid[2] = { 0xffffffff, 0x00ffffff };
> + static const u32 wcid[2] = { 0xffffffff, 0x00ffffff };
> rt2800_register_multiwrite(rt2x00dev, MAC_WCID_ENTRY(i),
> wcid, sizeof(wcid));
>
next prev parent reply other threads:[~2010-11-21 8:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 2:38 [PATCH 00/62] drivers/net: Use static const Joe Perches
2010-11-21 2:38 ` [PATCH 50/62] ar9170: Use const Joe Perches
2010-11-21 2:38 ` [PATCH 51/62] ath5k: Use static const Joe Perches
2010-11-21 2:38 ` [PATCH 52/62] ath9k: " Joe Perches
2010-11-21 2:38 ` [PATCH 53/62] carl9170: " Joe Perches
2010-11-21 2:38 ` [PATCH 54/62] atmel: " Joe Perches
2010-11-21 2:38 ` [PATCH 55/62] b43: " Joe Perches
2010-11-21 2:38 ` [PATCH 56/62] iwlwifi: " Joe Perches
2010-11-22 15:37 ` Guy, Wey-Yi
2010-11-21 2:38 ` [PATCH 57/62] libertas: " Joe Perches
2010-11-21 2:38 ` [PATCH 58/62] ray_cs: " Joe Perches
2010-11-21 2:39 ` [PATCH 59/62] rndis_wlan: " Joe Perches
2010-11-21 2:39 ` [PATCH 60/62] rt2x00: " Joe Perches
2010-11-21 8:58 ` Gertjan van Wingerde [this message]
2010-11-21 2:39 ` [PATCH 61/62] wl12xx: " Joe Perches
2010-11-21 2:39 ` [PATCH 62/62] zd1211rw: Use const Joe Perches
2010-11-21 4:50 ` [PATCH 00/62] drivers/net: Use static const David Miller
2010-11-22 22:10 ` Joe Perches
2010-11-22 22:19 ` David Miller
2010-11-22 22:40 ` Joe Perches
2010-11-23 16:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE8DF4F.5050803@gmail.com \
--to=gwingerde@gmail.com \
--cc=IvDoorn@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).