From: Felix Fietkau <nbd@openwrt.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, lrodriguez@atheros.com
Subject: Re: [PATCH] ath9k_hw: fix endian issues with CTLs on AR9003
Date: Mon, 22 Nov 2010 21:52:10 +0100 [thread overview]
Message-ID: <4CEAD7FA.1060107@openwrt.org> (raw)
In-Reply-To: <20101122201511.GG2117@tuxdriver.com>
On 2010-11-22 9:15 PM, John W. Linville wrote:
> On Sat, Nov 20, 2010 at 07:50:18PM +0100, Felix Fietkau wrote:
>> Parsing data using bitfields is messy, because it makes endian handling
>> much harder. AR9002 and earlier got it right, AR9003 got it wrong.
>> Fix it by getting rid of the CTL related bitfields entirely and use
>> masks instead.
>>
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>> Cc: stable@kernel.org
>
> Why does this merit stable consideration?
It's a simple fix and I would like it to make it to stable releases,
because this bug might possibly cause the tx power to be too high in
some instances (when running on big-endian systems), violating
regulatory limits.
- Felix
next prev parent reply other threads:[~2010-11-22 20:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-20 18:50 [PATCH] ath9k_hw: fix endian issues with CTLs on AR9003 Felix Fietkau
2010-11-22 20:15 ` John W. Linville
2010-11-22 20:52 ` Felix Fietkau [this message]
2010-11-29 19:50 ` John W. Linville
2010-11-29 21:19 ` Luis R. Rodriguez
2010-11-29 21:27 ` John W. Linville
2010-11-29 21:35 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEAD7FA.1060107@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).