From: Felix Fietkau <nbd@openwrt.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, lrodriguez@atheros.com
Subject: Re: [PATCH] ath9k_hw: fix more bitfield related endian issues
Date: Mon, 22 Nov 2010 22:06:59 +0100 [thread overview]
Message-ID: <4CEADB73.1050205@openwrt.org> (raw)
In-Reply-To: <20101122201541.GH2117@tuxdriver.com>
On 2010-11-22 9:15 PM, John W. Linville wrote:
> On Sat, Nov 20, 2010 at 08:22:50PM +0100, Felix Fietkau wrote:
>> A few LNA control related flags were also specified as a bitfields, however
>> for some strange reason they were written in big-endian order this time.
>> Fix this by using flags instead.
>>
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>> Cc: stable@kenrel.org
Oops.
> Why does this merit stable@kernel.org (misspelled, BTW) inclusion?
Trivial bug that can easily mess up baseband settings in some cases. Not
sure if it could also mess with tx power.
- Felix
next prev parent reply other threads:[~2010-11-22 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-20 19:22 [PATCH] ath9k_hw: fix more bitfield related endian issues Felix Fietkau
2010-11-22 20:15 ` John W. Linville
2010-11-22 21:06 ` Felix Fietkau [this message]
2010-11-29 19:51 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEADB73.1050205@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).