From: Ben Greear <greearb@candelatech.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
lrodriguez@atheros.com
Subject: Re: [PATCH 2/3] ath9k: fix timeout on stopping rx dma
Date: Mon, 22 Nov 2010 15:42:40 -0800 [thread overview]
Message-ID: <4CEAFFF0.3020401@candelatech.com> (raw)
In-Reply-To: <1290218928-87475-2-git-send-email-nbd@openwrt.org>
On 11/19/2010 06:08 PM, Felix Fietkau wrote:
> It seems that using ath9k_hw_stoppcurecv to stop rx dma is not enough.
> When it's time to stop DMA, the PCU is still busy, so the rx enable
> bit never clears.
> Using ath9k_hw_abortpcurecv helps with getting rx stopped much faster,
> with this change, I cannot reproduce the rx stop related WARN_ON anymore.
I have done some more testing, and several times it rebooted and
properly configured the 30 STAs & passed traffic without error.
So, it appears your change is definitely an improvement.
I did see one time earlier today when it still failed to stop,
however. Would it be worth attempting the abort and/or stop
hardware calls several times if it fails the first time?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-11-22 23:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-20 2:08 [PATCH 1/3] ath9k: fix recursive locking in the tx flush path Felix Fietkau
2010-11-20 2:08 ` [PATCH 2/3] ath9k: fix timeout on stopping rx dma Felix Fietkau
2010-11-20 2:08 ` [PATCH 3/3] ath9k_hw: remove ath9k_hw_stoppcurecv Felix Fietkau
2010-11-22 23:42 ` Ben Greear [this message]
2010-11-22 20:18 ` [PATCH 1/3] ath9k: fix recursive locking in the tx flush path Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEAFFF0.3020401@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).