[PATCH] wl12xx: Remove 11j channels from the supported channels list.

[PATCH] wl12xx: Remove 11j channels from the supported channels list.

[juuso.oikarinen]

From: Juuso Oikarinen <juuso.oikarinen@nokia.com>

Because we don't support them at this stage.

Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
---
 drivers/net/wireless/wl12xx/main.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index 7fecefe..dc3a093 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -2374,14 +2374,6 @@ static struct ieee80211_rate wl1271_rates_5ghz[] = {
 
 /* 5 GHz band channels for WL1273 */
 static struct ieee80211_channel wl1271_channels_5ghz[] = {
-	{ .hw_value = 183, .center_freq = 4915},
-	{ .hw_value = 184, .center_freq = 4920},
-	{ .hw_value = 185, .center_freq = 4925},
-	{ .hw_value = 187, .center_freq = 4935},
-	{ .hw_value = 188, .center_freq = 4940},
-	{ .hw_value = 189, .center_freq = 4945},
-	{ .hw_value = 192, .center_freq = 4960},
-	{ .hw_value = 196, .center_freq = 4980},
 	{ .hw_value = 7, .center_freq = 5035},
 	{ .hw_value = 8, .center_freq = 5040},
 	{ .hw_value = 9, .center_freq = 5045},
-- 
1.7.1

Re: [PATCH] wl12xx: Remove 11j channels from the supported channels list.

[Luciano Coelho]

On Mon, 2010-11-29 at 12:05 +0200, juuso.oikarinen@nokia.com wrote:
> From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> 
> Because we don't support them at this stage.
> 
> Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> ---

Looks good.  I'll apply it in the next round.

Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>

-- 
Cheers,
Luca.

Re: [PATCH] wl12xx: Remove 11j channels from the supported channels list.

[Gábor Stefanik]

On Mon, Nov 29, 2010 at 11:05 AM,  <juuso.oikarinen@nokia.com> wrote:
> From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
>
> Because we don't support them at this stage.
>
> Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> ---
>  drivers/net/wireless/wl12xx/main.c |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
> index 7fecefe..dc3a093 100644
> --- a/drivers/net/wireless/wl12xx/main.c
> +++ b/drivers/net/wireless/wl12xx/main.c
> @@ -2374,14 +2374,6 @@ static struct ieee80211_rate wl1271_rates_5ghz[] = {
>
>  /* 5 GHz band channels for WL1273 */
>  static struct ieee80211_channel wl1271_channels_5ghz[] = {

Is this for WL1271 or WL1273? The comment contradicts the name...

> -       { .hw_value = 183, .center_freq = 4915},
> -       { .hw_value = 184, .center_freq = 4920},
> -       { .hw_value = 185, .center_freq = 4925},
> -       { .hw_value = 187, .center_freq = 4935},
> -       { .hw_value = 188, .center_freq = 4940},
> -       { .hw_value = 189, .center_freq = 4945},
> -       { .hw_value = 192, .center_freq = 4960},
> -       { .hw_value = 196, .center_freq = 4980},
>        { .hw_value = 7, .center_freq = 5035},
>        { .hw_value = 8, .center_freq = 5040},
>        { .hw_value = 9, .center_freq = 5045},
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

Re: [PATCH] wl12xx: Remove 11j channels from the supported channels list.

[Luciano Coelho]

On Mon, 2010-11-29 at 13:06 +0100, ext Gábor Stefanik wrote:
> On Mon, Nov 29, 2010 at 11:05 AM,  <juuso.oikarinen@nokia.com> wrote:
> > From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> >
> > Because we don't support them at this stage.
> >
> > Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> > ---
> >  drivers/net/wireless/wl12xx/main.c |    8 --------
> >  1 files changed, 0 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
> > index 7fecefe..dc3a093 100644
> > --- a/drivers/net/wireless/wl12xx/main.c
> > +++ b/drivers/net/wireless/wl12xx/main.c
> > @@ -2374,14 +2374,6 @@ static struct ieee80211_rate wl1271_rates_5ghz[] = {
> >
> >  /* 5 GHz band channels for WL1273 */
> >  static struct ieee80211_channel wl1271_channels_5ghz[] = {
> 
> Is this for WL1271 or WL1273? The comment contradicts the name...

The wl1273 chip supports 5GHz channels.  The wl1271 chip doesn't.

The driver supports both wl1271 and wl1273.  We have even changed the
name to align with this (the driver is now called wl12xx).

We changed the file names and the module names already, but we haven't
changed the function and structure names yet.  At some point someone
will s/wl1271/wl12xx/.  Yes, it is confusing as it is right now, so
hopefully the renaming will happen soon.  Volunteers? ;)

-- 
Cheers,
Luca.

Re: [PATCH] wl12xx: Remove 11j channels from the supported channels list.

[Gery Kahn]

On 11/29/2010 12:05 PM, juuso.oikarinen@nokia.com wrote:
> From: Juuso Oikarinen<juuso.oikarinen@nokia.com>
>
> Because we don't support them at this stage.
>
> Signed-off-by: Juuso Oikarinen<juuso.oikarinen@nokia.com>
> ---
>   drivers/net/wireless/wl12xx/main.c |    8 --------
>   1 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
> index 7fecefe..dc3a093 100644
> --- a/drivers/net/wireless/wl12xx/main.c
> +++ b/drivers/net/wireless/wl12xx/main.c
> @@ -2374,14 +2374,6 @@ static struct ieee80211_rate wl1271_rates_5ghz[] = {
>
>   /* 5 GHz band channels for WL1273 */
>   static struct ieee80211_channel wl1271_channels_5ghz[] = {
> -	{ .hw_value = 183, .center_freq = 4915},
> -	{ .hw_value = 184, .center_freq = 4920},
> -	{ .hw_value = 185, .center_freq = 4925},
> -	{ .hw_value = 187, .center_freq = 4935},
> -	{ .hw_value = 188, .center_freq = 4940},
> -	{ .hw_value = 189, .center_freq = 4945},
> -	{ .hw_value = 192, .center_freq = 4960},
> -	{ .hw_value = 196, .center_freq = 4980},
>   	{ .hw_value = 7, .center_freq = 5035},
>   	{ .hw_value = 8, .center_freq = 5040},
>   	{ .hw_value = 9, .center_freq = 5045},
Our firmware do supports Japan channels, so why to remove them?

Re: [PATCH] wl12xx: Remove 11j channels from the supported channels list.

[Gery Kahn]

On 11/29/2010 02:26 PM, Luciano Coelho wrote:
> On Mon, 2010-11-29 at 13:06 +0100, ext Gábor Stefanik wrote:
>> On Mon, Nov 29, 2010 at 11:05 AM,<juuso.oikarinen@nokia.com>  wrote:
>>> From: Juuso Oikarinen<juuso.oikarinen@nokia.com>
>>>
>>> Because we don't support them at this stage.
>>>
>>> Signed-off-by: Juuso Oikarinen<juuso.oikarinen@nokia.com>
>>> ---
>>>   drivers/net/wireless/wl12xx/main.c |    8 --------
>>>   1 files changed, 0 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
>>> index 7fecefe..dc3a093 100644
>>> --- a/drivers/net/wireless/wl12xx/main.c
>>> +++ b/drivers/net/wireless/wl12xx/main.c
>>> @@ -2374,14 +2374,6 @@ static struct ieee80211_rate wl1271_rates_5ghz[] = {
>>>
>>>   /* 5 GHz band channels for WL1273 */
>>>   static struct ieee80211_channel wl1271_channels_5ghz[] = {
>>
>> Is this for WL1271 or WL1273? The comment contradicts the name...
>
> The wl1273 chip supports 5GHz channels.  The wl1271 chip doesn't.
>
> The driver supports both wl1271 and wl1273.  We have even changed the
> name to align with this (the driver is now called wl12xx).
>
> We changed the file names and the module names already, but we haven't
> changed the function and structure names yet.  At some point someone
> will s/wl1271/wl12xx/.  Yes, it is confusing as it is right now, so
> hopefully the renaming will happen soon.  Volunteers? ;)
>
is there enable_11a to use for?

Re: [PATCH] wl12xx: Remove 11j channels from the supported channels list.

[Luciano Coelho]

On Mon, 2010-11-29 at 14:34 +0200, ext Gery Kahn wrote:
> On 11/29/2010 12:05 PM, juuso.oikarinen@nokia.com wrote:
> > From: Juuso Oikarinen<juuso.oikarinen@nokia.com>
> >
> > Because we don't support them at this stage.
> >
> > Signed-off-by: Juuso Oikarinen<juuso.oikarinen@nokia.com>
> > ---
> >   drivers/net/wireless/wl12xx/main.c |    8 --------
> >   1 files changed, 0 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
> > index 7fecefe..dc3a093 100644
> > --- a/drivers/net/wireless/wl12xx/main.c
> > +++ b/drivers/net/wireless/wl12xx/main.c
> > @@ -2374,14 +2374,6 @@ static struct ieee80211_rate wl1271_rates_5ghz[] = {
> >
> >   /* 5 GHz band channels for WL1273 */
> >   static struct ieee80211_channel wl1271_channels_5ghz[] = {
> > -	{ .hw_value = 183, .center_freq = 4915},
> > -	{ .hw_value = 184, .center_freq = 4920},
> > -	{ .hw_value = 185, .center_freq = 4925},
> > -	{ .hw_value = 187, .center_freq = 4935},
> > -	{ .hw_value = 188, .center_freq = 4940},
> > -	{ .hw_value = 189, .center_freq = 4945},
> > -	{ .hw_value = 192, .center_freq = 4960},
> > -	{ .hw_value = 196, .center_freq = 4980},
> >   	{ .hw_value = 7, .center_freq = 5035},
> >   	{ .hw_value = 8, .center_freq = 5040},
> >   	{ .hw_value = 9, .center_freq = 5045},
> Our firmware do supports Japan channels, so why to remove them?

We experienced some problems with it (at least).  Juuso reported that
some strange things were happening, like probe_reqs were going to 2.4GHz
channels with 11a IEs when these 11j channels were scanned.

Have you actively tried to use 11j channels? Did you have any problems?

-- 
Cheers,
Luca.

Re: [PATCH] wl12xx: Remove 11j channels from the supported channels list.

[Luciano Coelho]

On Mon, 2010-11-29 at 14:41 +0200, ext Gery Kahn wrote:
> > We changed the file names and the module names already, but we
> haven't
> > changed the function and structure names yet.  At some point someone
> > will s/wl1271/wl12xx/.  Yes, it is confusing as it is right now, so
> > hopefully the renaming will happen soon.  Volunteers? ;)
> >
> is there enable_11a to use for? 

Sorry, I don't understand your question...

-- 
Cheers,
Luca.

Re: [PATCH] wl12xx: Remove 11j channels from the supported channels list.

[Juuso Oikarinen]

On Mon, 2010-11-29 at 22:10 +0200, Luciano Coelho wrote:
> On Mon, 2010-11-29 at 14:34 +0200, ext Gery Kahn wrote:
> > On 11/29/2010 12:05 PM, juuso.oikarinen@nokia.com wrote:
> > > From: Juuso Oikarinen<juuso.oikarinen@nokia.com>
> > >
> > > Because we don't support them at this stage.
> > >
> > > Signed-off-by: Juuso Oikarinen<juuso.oikarinen@nokia.com>
> > > ---
> > >   drivers/net/wireless/wl12xx/main.c |    8 --------
> > >   1 files changed, 0 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
> > > index 7fecefe..dc3a093 100644
> > > --- a/drivers/net/wireless/wl12xx/main.c
> > > +++ b/drivers/net/wireless/wl12xx/main.c
> > > @@ -2374,14 +2374,6 @@ static struct ieee80211_rate wl1271_rates_5ghz[] = {
> > >
> > >   /* 5 GHz band channels for WL1273 */
> > >   static struct ieee80211_channel wl1271_channels_5ghz[] = {
> > > -	{ .hw_value = 183, .center_freq = 4915},
> > > -	{ .hw_value = 184, .center_freq = 4920},
> > > -	{ .hw_value = 185, .center_freq = 4925},
> > > -	{ .hw_value = 187, .center_freq = 4935},
> > > -	{ .hw_value = 188, .center_freq = 4940},
> > > -	{ .hw_value = 189, .center_freq = 4945},
> > > -	{ .hw_value = 192, .center_freq = 4960},
> > > -	{ .hw_value = 196, .center_freq = 4980},
> > >   	{ .hw_value = 7, .center_freq = 5035},
> > >   	{ .hw_value = 8, .center_freq = 5040},
> > >   	{ .hw_value = 9, .center_freq = 5045},
> > Our firmware do supports Japan channels, so why to remove them?
> 
> We experienced some problems with it (at least).  Juuso reported that
> some strange things were happening, like probe_reqs were going to 2.4GHz
> channels with 11a IEs when these 11j channels were scanned.
> 
> Have you actively tried to use 11j channels? Did you have any problems?
> 

Yes, and also the NVS INI section (look at ini.h) appears to be
currently missing all the calibration/compensation etc values for the
11j channels.

So it seems even if the firmware may support 11j, the infrastructure on
the host side is still lacking. It seems to me there is some work to be
done before these can be enabled.

-Juuso

Re: [PATCH] wl12xx: Remove 11j channels from the supported channels list.

[Luciano Coelho]

On Mon, 2010-11-29 at 12:05 +0200, juuso.oikarinen@nokia.com wrote:
> From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> 
> Because we don't support them at this stage.
> 
> Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> ---

Applied and pushed to the wl12xx tree.  Thanks!


-- 
Cheers,
Luca.