From: Felix Fietkau <nbd@openwrt.org>
To: peter@stuge.se
Cc: ath9k-devel@lists.ath9k.org, linux-kernel@vger.kernel.org,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug
Date: Mon, 29 Nov 2010 23:41:27 +0100 [thread overview]
Message-ID: <4CF42C17.2070500@openwrt.org> (raw)
In-Reply-To: <20101129060732.5130.qmail@stuge.se>
On 2010-11-29 7:07 AM, Peter Stuge wrote:
> Luis R. Rodriguez wrote:
>> On Sun, Nov 28, 2010 at 3:53 PM, Joe Perches <joe@perches.com> wrote:
>> > Make the function name match the function purpose.
>> > ath_debug is a debug only facility.
>> > ath_print seems too generic a name for a debug only use.
>>
>> Nack, I don't see the point.
>
> The point is to improve readability. I like the patch.
And how exactly does this improve readability? Don't get me wrong, I
generally like to see more cleanups merged to the ath/ath9k drivers
(they do need it, after all).
But in my opinion, simple renaming churn like this does nothing but
annoy people who want to get other work done at the same time.
Consider the large number of lines touched (and the potential merge
conflicts with other code because of that), relative to the microscopic
aesthetic gain (if any).
Instead I'd like to see more cleanups that go beyond trivial function
renames.
- Felix
next prev parent reply other threads:[~2010-11-29 22:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 23:53 [PATCH wireless-next] ath: Rename ath_print to ath_debug Joe Perches
2010-11-29 2:17 ` Luis R. Rodriguez
[not found] ` <20101129060732.5130.qmail@stuge.se>
2010-11-29 22:41 ` Felix Fietkau [this message]
2010-11-29 22:42 ` [ath9k-devel] " Luis R. Rodriguez
2010-11-30 1:39 ` Joe Perches
2010-11-30 2:43 ` Felix Fietkau
2010-11-30 20:19 ` Joe Perches
2010-12-01 7:56 ` Luis R. Rodriguez
2010-12-01 7:59 ` Luis R. Rodriguez
2010-12-01 14:27 ` Joe Perches
2010-12-01 14:37 ` Felix Fietkau
2010-12-01 17:17 ` Joe Perches
2010-12-01 17:28 ` Joe Perches
2010-12-01 17:44 ` [PATCH] ath: Add and use ath_printk and ath_<level> Joe Perches
2010-12-01 18:05 ` [PATCH V2] " Joe Perches
2010-12-01 19:08 ` [PATCH] ath: Convert ath_print(.., ATH_DBG_FATAL to ath_err Joe Perches
2010-12-01 17:37 ` [PATCH wireless-next] MAINTAINERS: Add ATH GENERIC UTILITIES Joe Perches
2010-12-01 19:46 ` Luis R. Rodriguez
2010-12-01 20:16 ` Joe Perches
2010-12-01 20:18 ` Luis R. Rodriguez
2010-12-01 20:41 ` [ath9k-devel] " Luis R. Rodriguez
2010-12-02 0:48 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF42C17.2070500@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=peter@stuge.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).