From: Shahar Levi <shahar_levi@ti.com>
To: Luciano Coelho <luciano.coelho@nokia.com>
Cc: ext Ohad Ben-Cohen <ohad@wizery.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v4 ] wl12xx: BA Initiator support
Date: Tue, 30 Nov 2010 11:06:15 +0200 [thread overview]
Message-ID: <4CF4BE87.5060307@ti.com> (raw)
In-Reply-To: <1291101352.1673.112.camel@powerslave>
On 11/30/2010 09:15 AM, Luciano Coelho wrote:
> On Mon, 2010-11-29 at 23:07 -0800, ext Ohad Ben-Cohen wrote:
>> On Mon, Nov 29, 2010 at 10:11 PM, Luciano Coelho
>> <luciano.coelho@nokia.com> wrote:
>> ...
>>> In theory the API *has* changed, not just extended. Check this:
>>>
>>> - ACX_BA_SESSION_RESPONDER_POLICY = 0x0055,
>>> - ACX_BA_SESSION_INITIATOR_POLICY = 0x0056,
>>> + ACX_BA_SESSION_POLICY_CFG = 0x0055,
>>> + ACX_BA_SESSION_RX_SETUP = 0x0056,
>>>
>>> But in practice, this doesn't matter, because we were not using the
>>> RESPONDER/INITIATOR commands before...
>>
>> Right. So an old driver will still work with this new firmware.
>>
>>> It's basically just those two extra commands that were added. And one
>>> new event that is part of a future patch.
>>>
>>> In theory, we could check the firmware revision after boot and bail out
>>> if the version doesn't match.
>>
>> Why not just disable BA sessions in this case (and keep that new event
>> masked), and let the driver keep running (just like it does today) ?
>>
>> This way the new driver will work even with the old firmware (yes,
>> with degraded functionality, but most random ppl will just not care),
>> and of course, the old driver will keep working with the new firmware.
>>
>> For us developers who lurk in linux-wireless it seems like a trivial
>> change, but if we consider the growing size of the 12xx community, and
>> the long period of time for which such a change will be effective (ppl
>> upgrading to latest compat, ppl that will one day upgrade to 2.6.38,
>> future ppl that will bisect and cross this firmware name change,
>> etc...), it's actually a lot of accumulated pain.
>>
>> To keep our community happy, I vote to eliminate this pain when not necessary.
>
> Hear, hear!
>
> Shahar, can you fix that?
Yes, will do.
Shahar
prev parent reply other threads:[~2010-11-30 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 13:42 [PATCH v4 ] wl12xx: BA Initiator support Shahar Levi
2010-11-30 0:44 ` Ohad Ben-Cohen
2010-11-30 6:11 ` Luciano Coelho
2010-11-30 7:07 ` Ohad Ben-Cohen
2010-11-30 7:15 ` Luciano Coelho
2010-11-30 9:06 ` Shahar Levi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF4BE87.5060307@ti.com \
--to=shahar_levi@ti.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).