From: Felix Fietkau <nbd@openwrt.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, lrodriguez@atheros.com
Subject: Re: [PATCH 2.6.37 v2 1/2] ath9k_hw: fix endian issues with CTLs on AR9003
Date: Tue, 30 Nov 2010 19:46:57 +0100 [thread overview]
Message-ID: <4CF546A1.1060904@openwrt.org> (raw)
In-Reply-To: <20101130182715.GD2341@tuxdriver.com>
On 2010-11-30 7:27 PM, John W. Linville wrote:
> On Tue, Nov 30, 2010 at 04:35:37PM +0100, Felix Fietkau wrote:
>> Parsing data using bitfields is messy, because it makes endian handling
>> much harder. AR9002 and earlier got it right, AR9003 got it wrong.
>> This might lead to either using too high or too low tx power values,
>> depending on frequency and eeprom settings.
>> Fix it by getting rid of the CTL related bitfields entirely and use
>> masks instead.
Oh, sorry, sent it from the wrong tree. Will resend...
prev parent reply other threads:[~2010-11-30 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 15:35 [PATCH 2.6.37 v2 1/2] ath9k_hw: fix endian issues with CTLs on AR9003 Felix Fietkau
2010-11-30 15:35 ` [PATCH 2.6.37 v2 2/2] ath9k_hw: fix more bitfield related endian issues Felix Fietkau
2010-11-30 18:27 ` [PATCH 2.6.37 v2 1/2] ath9k_hw: fix endian issues with CTLs on AR9003 John W. Linville
2010-11-30 18:46 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF546A1.1060904@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).