From: Ben Greear <greearb@candelatech.com>
To: Senthil Balasubramanian <senthilkumar@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Stable <stable@kernel.org>,
Kyungwan Nam <Kyungwan.Nam@atheros.com>
Subject: Re: [PATCH v2 2/2] ath9k: Fix STA disconnect issue due to received MIC failed bcast frames
Date: Wed, 01 Dec 2010 11:58:53 -0800 [thread overview]
Message-ID: <4CF6A8FD.6020508@candelatech.com> (raw)
In-Reply-To: <1291201205-1541-1-git-send-email-senthilkumar@atheros.com>
On 12/01/2010 03:00 AM, Senthil Balasubramanian wrote:
> AR_RxKeyIdxValid will not be set for bcast/mcast frames and so relying
> this status for MIC failed frames is buggy.
>
> Due to this, MIC failure events for broadcast frames are not sent to
> supplicant resulted in AP disconnecting the STA.
>
> Able to pass Wifi Test case 5.2.18 with this fix.
Please do not apply this yet. As far as I can tell, either
of these patches breaks multiple VIF scenarios. I'm not
sure exactly why, but I had to revert this to get any
of my interfaces to associate.
I'm using software encryption in case that matters.
Senthil: Any chance you could test with a few VIFS to
see if you see the same problem?
Here is a dmesg snippet from wireless-testing with the v1 reverted
and v2 applied:
sta9: authenticate with 00:14:d1:c6:d2:54 (try 1)
sta9: authenticated
sta9: associate with 00:14:d1:c6:d2:54 (try 1)
sta9: RX AssocResp from 00:14:d1:c6:d2:54 (capab=0x431 status=1 aid=0)
sta9: 00:14:d1:c6:d2:54 denied association (code=1)
sta9: deauthenticating from 00:14:d1:c6:d2:54 by local choice (reason=3)
ieee80211 wiphy0: device now idle
ieee80211 wiphy0: device no longer idle - scanning
ieee80211 wiphy0: device now idle
ieee80211 wiphy0: device no longer idle - working
sta10: authenticate with 00:14:d1:c6:d2:54 (try 1)
sta10: authenticated
sta10: associate with 00:14:d1:c6:d2:54 (try 1)
sta10: RX AssocResp from 00:14:d1:c6:d2:54 (capab=0x431 status=1 aid=0)
sta10: 00:14:d1:c6:d2:54 denied association (code=1)
sta10: deauthenticating from 00:14:d1:c6:d2:54 by local choice (reason=3)
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-12-01 20:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 11:00 [PATCH v2 2/2] ath9k: Fix STA disconnect issue due to received MIC failed bcast frames Senthil Balasubramanian
2010-12-01 19:58 ` Ben Greear [this message]
2010-12-02 5:09 ` Mohammed Shafi
2010-12-02 5:44 ` Ben Greear
2010-12-02 7:16 ` Mohammed Shafi
2010-12-03 8:04 ` Ben Greear
2010-12-03 14:17 ` Senthil Balasubramanian
2010-12-03 17:58 ` Ben Greear
2010-12-06 11:31 ` Senthil Balasubramanian
2010-12-02 19:17 ` John W. Linville
2010-12-03 8:44 ` Senthil Balasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF6A8FD.6020508@candelatech.com \
--to=greearb@candelatech.com \
--cc=Kyungwan.Nam@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=senthilkumar@atheros.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).