From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH 1/4] b43: N-PHY: update init tables
Date: Tue, 07 Dec 2010 20:08:42 +0100 [thread overview]
Message-ID: <4CFE863A.30203@hauke-m.de> (raw)
In-Reply-To: <1291711327-4690-1-git-send-email-zajec5@gmail.com>
On 12/07/2010 09:42 AM, Rafał Miłecki wrote:
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> drivers/net/wireless/b43/tables_nphy.c | 212 ++++++++++++++++----------------
> 1 files changed, 106 insertions(+), 106 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/tables_nphy.c b/drivers/net/wireless/b43/tables_nphy.c
> index d60db07..46f0a7a 100644
> --- a/drivers/net/wireless/b43/tables_nphy.c
> +++ b/drivers/net/wireless/b43/tables_nphy.c
> @@ -28,41 +28,41 @@
> #include "phy_n.h"
>
> static const u8 b43_ntab_adjustpower0[] = {
> - 0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01,
> - 0x02, 0x02, 0x02, 0x02, 0x03, 0x03, 0x03, 0x03,
> - 0x04, 0x04, 0x04, 0x04, 0x05, 0x05, 0x05, 0x05,
> - 0x06, 0x06, 0x06, 0x06, 0x07, 0x07, 0x07, 0x07,
> - 0x08, 0x08, 0x08, 0x08, 0x09, 0x09, 0x09, 0x09,
> - 0x0A, 0x0A, 0x0A, 0x0A, 0x0B, 0x0B, 0x0B, 0x0B,
> - 0x0C, 0x0C, 0x0C, 0x0C, 0x0D, 0x0D, 0x0D, 0x0D,
> - 0x0E, 0x0E, 0x0E, 0x0E, 0x0F, 0x0F, 0x0F, 0x0F,
> - 0x10, 0x10, 0x10, 0x10, 0x11, 0x11, 0x11, 0x11,
> - 0x12, 0x12, 0x12, 0x12, 0x13, 0x13, 0x13, 0x13,
> - 0x14, 0x14, 0x14, 0x14, 0x15, 0x15, 0x15, 0x15,
> - 0x16, 0x16, 0x16, 0x16, 0x17, 0x17, 0x17, 0x17,
> - 0x18, 0x18, 0x18, 0x18, 0x19, 0x19, 0x19, 0x19,
> - 0x1A, 0x1A, 0x1A, 0x1A, 0x1B, 0x1B, 0x1B, 0x1B,
> - 0x1C, 0x1C, 0x1C, 0x1C, 0x1D, 0x1D, 0x1D, 0x1D,
> - 0x1E, 0x1E, 0x1E, 0x1E, 0x1F, 0x1F, 0x1F, 0x1F,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> };
Why do you have this table when it only contains 0x00? If it is correct
there will be a better way to define such a table.
>
> static const u8 b43_ntab_adjustpower1[] = {
> - 0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01,
> - 0x02, 0x02, 0x02, 0x02, 0x03, 0x03, 0x03, 0x03,
> - 0x04, 0x04, 0x04, 0x04, 0x05, 0x05, 0x05, 0x05,
> - 0x06, 0x06, 0x06, 0x06, 0x07, 0x07, 0x07, 0x07,
> - 0x08, 0x08, 0x08, 0x08, 0x09, 0x09, 0x09, 0x09,
> - 0x0A, 0x0A, 0x0A, 0x0A, 0x0B, 0x0B, 0x0B, 0x0B,
> - 0x0C, 0x0C, 0x0C, 0x0C, 0x0D, 0x0D, 0x0D, 0x0D,
> - 0x0E, 0x0E, 0x0E, 0x0E, 0x0F, 0x0F, 0x0F, 0x0F,
> - 0x10, 0x10, 0x10, 0x10, 0x11, 0x11, 0x11, 0x11,
> - 0x12, 0x12, 0x12, 0x12, 0x13, 0x13, 0x13, 0x13,
> - 0x14, 0x14, 0x14, 0x14, 0x15, 0x15, 0x15, 0x15,
> - 0x16, 0x16, 0x16, 0x16, 0x17, 0x17, 0x17, 0x17,
> - 0x18, 0x18, 0x18, 0x18, 0x19, 0x19, 0x19, 0x19,
> - 0x1A, 0x1A, 0x1A, 0x1A, 0x1B, 0x1B, 0x1B, 0x1B,
> - 0x1C, 0x1C, 0x1C, 0x1C, 0x1D, 0x1D, 0x1D, 0x1D,
> - 0x1E, 0x1E, 0x1E, 0x1E, 0x1F, 0x1F, 0x1F, 0x1F,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> };
Same here.
Hauke
next prev parent reply other threads:[~2010-12-07 19:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 8:42 [PATCH 1/4] b43: N-PHY: update init tables Rafał Miłecki
2010-12-07 8:42 ` [PATCH 2/4] b43: N-PHY: reorder and optimize tables initialization Rafał Miłecki
2010-12-07 8:42 ` [PATCH 3/4] b43: N-PHY: implement own maskset Rafał Miłecki
2010-12-07 8:42 ` [PATCH 4/4] b43: flush PHY writes when needed Rafał Miłecki
2010-12-07 19:08 ` Hauke Mehrtens [this message]
2010-12-07 19:19 ` [PATCH 1/4] b43: N-PHY: update init tables Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2010-12-07 19:49 ikorot
2010-12-07 20:00 ` Larry Finger
2010-12-08 1:55 ikorot
2010-12-09 14:06 ` Rafał Miłecki
2010-12-10 2:26 ikorot
2010-12-10 6:36 ` Rafał Miłecki
2010-12-10 19:09 ikorot
2010-12-10 19:33 ` Rafał Miłecki
2010-12-10 21:54 ikorot
2010-12-10 22:03 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFE863A.30203@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).