From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>,
Ben Greear <greearb@candelatech.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Compile problem in ath9k with ATH_DBG_WARN_ON_ONCE
Date: Thu, 09 Dec 2010 14:47:22 +0100 [thread overview]
Message-ID: <4D00DDEA.7040907@hauke-m.de> (raw)
Hi,
I got an compile problem in drivers/net/wireless/ath/ath9k/main.c
This is caused by commit ff9f0b639f33c92a89b0799263ab625444be6ee1
ath9k: skip ATH9K_INT_TIM_TIMER when we are idle
and d7fd1b50a51be3fe6554fbab8953fa8a3ff4009b
ath9k: Make DMA warning in ath_stoprecv WARN_ON_ONCE.
If CONFIG_ATH_DEBUG=y is set ATH_DBG_WARN_ON_ONCE uses WARN_ON_ONCE and
returns something, but if CONFIG_ATH_DEBUG is not set it does not return
anything. Now ATH_DBG_WARN_ON_ONCE is used in the boolean expression in
an if case and is not returning anything and causes a compile error.
CC [M] /drivers/net/wireless/ath/ath9k/main.o
/drivers/net/wireless/ath/ath9k/main.c: In function ‘ath_isr’:
/drivers/net/wireless/ath/ath9k/main.c:769: error: expected expression
before ‘do’
make[5]: *** [/drivers/net/wireless/ath/ath9k/main.o] Error 1
make[4]: *** [/drivers/net/wireless/ath/ath9k] Error 2
Hauke
next reply other threads:[~2010-12-09 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 13:47 Hauke Mehrtens [this message]
2010-12-09 14:12 ` [PATCH] ath: fix build break with ATH_DBG_WARN_ON_ONCE John W. Linville
2010-12-09 14:17 ` Johannes Berg
2010-12-09 14:42 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D00DDEA.7040907@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).