From: Felix Fietkau <nbd@openwrt.org>
To: Sujith <m.sujith@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Sujith.Manoharan@atheros.com
Subject: Re: [PATCH] ath9k_htc: Remove PCI specific configuration
Date: Tue, 14 Dec 2010 11:48:07 +0100 [thread overview]
Message-ID: <4D074B67.9050309@openwrt.org> (raw)
In-Reply-To: <19718.55706.982211.137208@gargle.gargle.HOWL>
On 2010-12-14 3:42 AM, Sujith wrote:
> From: Sujith Manoharan <Sujith.Manoharan@atheros.com>
>
> There is no need to configure PCI related registers for
> USB devices.
>
> Signed-off-by: Sujith Manoharan <Sujith.Manoharan@atheros.com>
> ---
> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
> index 0f373be..2662553 100644
> --- a/drivers/net/wireless/ath/ath9k/hw.c
> +++ b/drivers/net/wireless/ath/ath9k/hw.c
> @@ -568,10 +568,12 @@ static int __ath9k_hw_init(struct ath_hw *ah)
> ah->WARegVal |= (AR_WA_D3_L1_DISABLE |
> AR_WA_ASPM_TIMER_BASED_DISABLE);
>
> - if (ah->is_pciexpress)
> + if (ah->is_pciexpress) {
> ath9k_hw_configpcipowersave(ah, 0, 0);
> - else
> - ath9k_hw_disablepcie(ah);
> + } else {
> + if (common->bus_ops->ath_bus_type != ATH_USB)
> + ath9k_hw_disablepcie(ah);
> + }
I don't really see the point of this check, since (with my other patch)
ath9k_hw_disablepcie already checks for AR_SREV_5416, which won't return
true on any USB based device.
- Felix
next prev parent reply other threads:[~2010-12-14 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 2:42 [PATCH] ath9k_htc: Remove PCI specific configuration Sujith
2010-12-14 10:48 ` Felix Fietkau [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-15 2:17 Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D074B67.9050309@openwrt.org \
--to=nbd@openwrt.org \
--cc=Sujith.Manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m.sujith@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).