From: Andy Lutomirski <luto@mit.edu>
To: Sujith <m.sujith@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Sujith.Manoharan@atheros.com
Subject: Re: [PATCH] mac80211: Add timeout to BA session start API
Date: Wed, 15 Dec 2010 07:56:53 -0500 [thread overview]
Message-ID: <4D08BB15.5070803@mit.edu> (raw)
In-Reply-To: <19720.9510.589223.207856@gargle.gargle.HOWL>
Sujith wrote:
> From: Sujith Manoharan <Sujith.Manoharan-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org>
>
> Allow drivers or rate control algorithms to specify BlockAck session
> timeout when initiating an ADDBA transaction. This is useful in cases
> where maintaining persistent BA sessions does not incur any overhead.
>
> The current timeout value of 5000 TUs is retained for all non ath9k/ath9k_htc
> drivers.
>
> Signed-off-by: Sujith Manoharan <Sujith.Manoharan-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org>
> ---
> drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 2 +-
> drivers/net/wireless/ath/ath9k/rc.c | 2 +-
> drivers/net/wireless/iwlwifi/iwl-agn-rs.c | 2 +-
> include/net/mac80211.h | 4 +++-
> net/mac80211/agg-tx.c | 7 +++++--
> net/mac80211/debugfs_sta.c | 2 +-
> net/mac80211/rc80211_minstrel_ht.c | 2 +-
> net/mac80211/sta_info.h | 2 ++
> 8 files changed, 15 insertions(+), 8 deletions(-)
>
[...]
> diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
> index 4ad7a36..165a451 100644
> --- a/net/mac80211/rc80211_minstrel_ht.c
> +++ b/net/mac80211/rc80211_minstrel_ht.c
> @@ -374,7 +374,7 @@ minstrel_aggr_check(struct minstrel_priv *mp, struct ieee80211_sta *pubsta, stru
> if (skb_get_queue_mapping(skb) == IEEE80211_AC_VO)
> return;
>
> - ieee80211_start_tx_ba_session(pubsta, tid);
> + ieee80211_start_tx_ba_session(pubsta, tid, 5000);
What about ath9k with minstrel_ht as rc? A lot of openwrt users (e.g. me) use
this.
--Andy
prev parent reply other threads:[~2010-12-15 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 2:17 [PATCH] mac80211: Add timeout to BA session start API Sujith
2010-12-15 9:12 ` Johannes Berg
[not found] ` <19720.35054.401355.825223@gargle.gargle.HOWL>
2010-12-15 9:29 ` Johannes Berg
2010-12-15 12:56 ` Andy Lutomirski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D08BB15.5070803@mit.edu \
--to=luto@mit.edu \
--cc=Sujith.Manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m.sujith@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).