From: Roger Quadros <roger.quadros@nokia.com>
To: Luciano Coelho <luciano.coelho@nokia.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] wl12xx_sdio_test: rename files to match current style
Date: Wed, 15 Dec 2010 17:16:44 +0200 [thread overview]
Message-ID: <4D08DBDC.5070908@nokia.com> (raw)
In-Reply-To: <1292424501.32385.10.camel@chilepepper>
On 12/15/2010 04:48 PM, Luciano Coelho wrote:
> On Wed, 2010-12-15 at 16:33 +0200, ext Luciano Coelho wrote:
>> On Wed, 2010-12-15 at 16:31 +0200, luciano.coelho@nokia.com wrote:
>>> From: Luciano Coelho<luciano.coelho@nokia.com>
>>>
>>> Change some file names and Kconfig settings so that this new module matches
>>> the new way of using wl12xx instead of wl1271.
>>>
>>> Also fix SDIO power enabling and disabling to match the latest way of doing
>>> it.
>>>
>>> Cc: Roger Quadros<roger.quadros@nokia.com>
>>> Signed-off-by: Luciano Coelho<luciano.coelho@nokia.com>
>>> ---
>>
>> In v2 I used the -M flag (to detect renames, which I stupidly forgot
>> before) and removed the file names from the header of the sdio_test.c
>> file, since it's a bad idea to have it there (thanks Johannes for the
>> comments).
>
> Roger, I have just compile-tested this module in upstream. Could you
> run at least some basic tests with it to make sure it works?
>
>
Luca,
I don't have a ready setup with me which boots mainline kernel and has wl1271 on
sdio.
The only way to verify it is to load the module with the parameters rx=1 and
tx=1 and see if the "testing started" message appears.
what platform do you use to verify with mainline kernel & sdio wl1271 ?
--
regards,
-roger
next prev parent reply other threads:[~2010-12-15 15:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 14:31 [PATCH v2] wl12xx_sdio_test: rename files to match current style luciano.coelho
2010-12-15 14:33 ` Luciano Coelho
2010-12-15 14:48 ` Luciano Coelho
2010-12-15 15:16 ` Roger Quadros [this message]
2010-12-16 9:04 ` Luciano Coelho
2010-12-16 9:12 ` Roger Quadros
2010-12-16 9:26 ` Luciano Coelho
2010-12-15 15:10 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D08DBDC.5070908@nokia.com \
--to=roger.quadros@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).