From: Larry Finger <Larry.Finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 00/22] rtl8192ce: Initial upload of driver
Date: Wed, 15 Dec 2010 11:12:44 -0600 [thread overview]
Message-ID: <4D08F70C.4060302@lwfinger.net> (raw)
In-Reply-To: <20101215163730.GF2377@tuxdriver.com>
On 12/15/2010 10:37 AM, John W. Linville wrote:
> On Wed, Dec 15, 2010 at 05:26:40PM +0100, Johannes Berg wrote:
>
>>> If you prefer that it go to staging first, I will send it to GregKH, but since
>>> it uses mac80211, I think it is ready for wireless.
>>
>> It looks pretty clean -- so personally, I don't think I'd mind it going
>> in directly.
>>
>> Are you or somebody else planning to make changes to it though? It looks
>> like for example the config semaphore could easily be replaced by a
>> mutex for better debug, for example. Potentially, rate control could be
>> internalised with IEEE80211_HW_HAS_RATE_CONTROL as well, and some
>> similar minor things.
Certainly, the semaphore can be replaced with a mutex. I will need to think
about the rate control.
>
> Sorry for the delay, Larry! I've been meaning to post a thorough
> review, but...busy, busy...
>
> Anyway, I think Johannes is right -- whatever issues remain, it
> would be better to get it in place now than to leave it out or push
> it to staging.
>
> I intend to mash the series together into a single patch when I merge
> it -- I hope you don't mind.
No, I don't mind. I just put it as multiple patches for review. One nice thing
about being retired is that I don't have to deal with any bean counters who
might worry about number or lines of patches - only making Linux better.
If you want, I can make it a single patch and put it in the git tree I mentioned
for you to pull.
Larry
next prev parent reply other threads:[~2010-12-15 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 16:18 [PATCH 00/22] rtl8192ce: Initial upload of driver Larry Finger
2010-12-15 16:26 ` Johannes Berg
2010-12-15 16:37 ` John W. Linville
2010-12-15 17:12 ` Larry Finger [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-08 17:12 Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D08F70C.4060302@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).