Re: [PATCH 00/22] rtl8192ce: Initial upload of driver

Re: [PATCH 00/22] rtl8192ce: Initial upload of driver

[Larry Finger]

John,

What is the status of the driver that was submitted in this patch set? There has
been no ACK, but on the other hand, neither the RFC nor the PATCH set got any
negative or positive comments. These devices are in the wild and several users
on the openSUSE forum have needed help is setting up the vendor driver on which
this one is based.

If you prefer that it go to staging first, I will send it to GregKH, but since
it uses mac80211, I think it is ready for wireless.

Thanks,

Larry

Re: [PATCH 00/22] rtl8192ce: Initial upload of driver

[Johannes Berg]

Larry,

> If you prefer that it go to staging first, I will send it to GregKH, but since
> it uses mac80211, I think it is ready for wireless.

It looks pretty clean -- so personally, I don't think I'd mind it going
in directly.

Are you or somebody else planning to make changes to it though? It looks
like for example the config semaphore could easily be replaced by a
mutex for better debug, for example. Potentially, rate control could be
internalised with IEEE80211_HW_HAS_RATE_CONTROL as well, and some
similar minor things.

johannes

Re: [PATCH 00/22] rtl8192ce: Initial upload of driver

[John W. Linville]

On Wed, Dec 15, 2010 at 05:26:40PM +0100, Johannes Berg wrote:

> > If you prefer that it go to staging first, I will send it to GregKH, but since
> > it uses mac80211, I think it is ready for wireless.
> 
> It looks pretty clean -- so personally, I don't think I'd mind it going
> in directly.
> 
> Are you or somebody else planning to make changes to it though? It looks
> like for example the config semaphore could easily be replaced by a
> mutex for better debug, for example. Potentially, rate control could be
> internalised with IEEE80211_HW_HAS_RATE_CONTROL as well, and some
> similar minor things.

Sorry for the delay, Larry!  I've been meaning to post a thorough
review, but...busy, busy...

Anyway, I think Johannes is right -- whatever issues remain, it
would be better to get it in place now than to leave it out or push
it to staging.

I intend to mash the series together into a single patch when I merge
it -- I hope you don't mind.

Thanks,

JOhn
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH 00/22] rtl8192ce: Initial upload of driver

[Larry Finger]

On 12/15/2010 10:37 AM, John W. Linville wrote:
> On Wed, Dec 15, 2010 at 05:26:40PM +0100, Johannes Berg wrote:
> 
>>> If you prefer that it go to staging first, I will send it to GregKH, but since
>>> it uses mac80211, I think it is ready for wireless.
>>
>> It looks pretty clean -- so personally, I don't think I'd mind it going
>> in directly.
>>
>> Are you or somebody else planning to make changes to it though? It looks
>> like for example the config semaphore could easily be replaced by a
>> mutex for better debug, for example. Potentially, rate control could be
>> internalised with IEEE80211_HW_HAS_RATE_CONTROL as well, and some
>> similar minor things.

Certainly, the semaphore can be replaced with a mutex. I will need to think
about the rate control.
> 
> Sorry for the delay, Larry!  I've been meaning to post a thorough
> review, but...busy, busy...
> 
> Anyway, I think Johannes is right -- whatever issues remain, it
> would be better to get it in place now than to leave it out or push
> it to staging.
> 
> I intend to mash the series together into a single patch when I merge
> it -- I hope you don't mind.

No, I don't mind. I just put it as multiple patches for review. One nice thing
about being retired is that I don't have to deal with any bean counters who
might worry about number or lines of patches - only making Linux better.

If you want, I can make it a single patch and put it in the git tree I mentioned
for you to pull.

Larry

[PATCH 00/22] rtl8192ce: Initial upload of driver

[Larry Finger]

This patch bomb contains a driver for Realtek RTL8192CE and RTL8188CE PCIe
devices. The firmware for this driver will be sent to linux-firmware.

[PATCH 01/22] rtl8192ce: Add files to rtlwifi - Part 1: core.{c,h}
[PATCH 02/22] rtl8192ce: Add files to rtlwifi - Part 2: base.{c,h}
[PATCH 03/22] rtl8192ce: Add files to rtlwifi - Part 3: cam.{c,h}
[PATCH 04/22] rtl8192ce: Add files to rtlwifi - Part 4: debug.{c,h}
[PATCH 05/22] rtl8192ce: Add files to rtlwifi - Part 5: efuse.{c,h}
[PATCH 06/22] rtl8192ce: Add files to rtlwifi - Part 6: pci.{c,h}
[PATCH 07/22] rtl8192ce: Add files to rtlwifi - Part 7: ps.{c,h}
[PATCH 08/22] rtl8192ce: Add files to rtlwifi - Part 8: rc.{c,h}
[PATCH 09/22] rtl8192ce: Add files to rtlwifi - Part 9: regd.{c,h}
[PATCH 10/22] rtl8192ce: Add files to rtlwifi - Part 10: wifi.h
[PATCH 11/22] rtl8192ce: Add files to rtlwifi - Part 11: Kconfig and Makefile
[PATCH 12/22] rtl8192ce: Add files to rtlwifi/rtl8192ce - Part 12: rtl8192c-dm.{c,h}
[PATCH 13/22] rtl8192ce: Add files to rtlwifi/rtl8192ce - Part 13: rtl8192c-fw.{c,h}
[PATCH 14/22] rtl8192ce: Add files to rtlwifi/rtl8192ce - Part 14: rtl8192c-hw.{c,h}
[PATCH 15/22] rtl8192ce: Add files to rtlwifi/rtl8192ce - Part 15: rtl8192c-led.{c,h}
[PATCH 16/22] rtl8192ce: Add files to rtlwifi/rtl8192ce - Part 16: rtl8192c-phy.{c,h}
[PATCH 17/22] rtl8192ce: Add files to rtlwifi/rtl8192ce - Part 17: rtl8192c-sw.{c,h}
[PATCH 18/22] rtl8192ce: Add files to rtlwifi/rtl8192ce - Part 18: rtl8192c-rf.{c,h}
[PATCH 19/22] rtl8192ce: Add files to rtlwifi/rtl8192ce - Part 19: rtl8192c-table.{c,h}
[PATCH 20/22] rtl8192ce: Add files to rtlwifi/rtl8192ce - Part 20: rtl8192c-trx.{c,h}
[PATCH 21/22] rtl8192ce: Add files to rtlwifi/rtl8192ce - Part 21: rtl8192c-def.h,
[PATCH 22/22] rtl8192ce: Part 22: Update drivers/net/wireless/Kconfig and Makefile

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---

John,

This driver is intended for wireless-testing and kernel 2.6.38. You can pull it
from git://git.kernel.org/pub/scm/linux/kernel/git/lwfinger/rtl8192ce.git.

Thanks,

Larry