From: Tejun Heo <tj@kernel.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [RFT] rtlwifi: use alloc_workqueue
Date: Fri, 17 Dec 2010 10:57:13 +0100 [thread overview]
Message-ID: <4D0B33F9.2030302@kernel.org> (raw)
In-Reply-To: <4D0ADCBC.1000300@lwfinger.net>
Hello,
On 12/17/2010 04:45 AM, Larry Finger wrote:
> On 12/16/2010 01:59 PM, John W. Linville wrote:
>> create_workqueue is deprecated. The workqueue usage does not seem to
>> demand any special treatment, so do not set any flags either.
>>
>> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>> ---
>> I don't have the hardware to test...
>
> Hold off on this one. It seems to break the driver, but I do not
> know why just yet.
There are two differences between create_workqueue(name) and
alloc_workqueue(name, 0, 0).
* The former has WQ_MEM_RECLAIM set and forward progress is guaranteed
regardless of memory pressure. In this case, this shouldn't make
any difference.
* The former has @max_active set to 1 while the latter to
WQ_DFL_ACTIVE. IOW, works queued on the same CPU would be allowed
to run concurrently while before conversion only different CPUs can
run works queued to the workqueue in parallel. This usually
shouldn't make difference either as works could have run in parallel
on different CPUs before too.
Does alloc_workqueue(name, 0, 1) fix the problem? If so, it might be
that the current workqueue usage has problem too.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-12-17 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 19:59 [RFT] rtlwifi: use alloc_workqueue John W. Linville
2010-12-17 3:45 ` Larry Finger
2010-12-17 9:57 ` Tejun Heo [this message]
2010-12-18 1:29 ` Larry Finger
2010-12-18 7:13 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0B33F9.2030302@kernel.org \
--to=tj@kernel.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).