From: Larry Finger <Larry.Finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: Re: [RFT] rtlwifi: use alloc_workqueue
Date: Fri, 17 Dec 2010 19:29:03 -0600 [thread overview]
Message-ID: <4D0C0E5F.4030605@lwfinger.net> (raw)
In-Reply-To: <1292529589-5904-1-git-send-email-linville@tuxdriver.com>
On 12/16/2010 01:59 PM, John W. Linville wrote:
> create_workqueue is deprecated. The workqueue usage does not seem to
> demand any special treatment, so do not set any flags either.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> I don't have the hardware to test...
>
> drivers/net/wireless/rtlwifi/base.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/base.c b/drivers/net/wireless/rtlwifi/base.c
> index 9e860ff..24a7cd3 100644
> --- a/drivers/net/wireless/rtlwifi/base.c
> +++ b/drivers/net/wireless/rtlwifi/base.c
> @@ -225,7 +225,7 @@ static void _rtl_init_deferred_work(struct ieee80211_hw *hw)
>
> /* <2> work queue */
> rtlpriv->works.hw = hw;
> - rtlpriv->works.rtl_wq = create_workqueue(rtlpriv->cfg->name);
> + rtlpriv->works.rtl_wq = alloc_workqueue(rtlpriv->cfg->name, 0, 0);
> INIT_DELAYED_WORK(&rtlpriv->works.watchdog_wq,
> (void *)rtl_watchdog_wq_callback);
> INIT_DELAYED_WORK(&rtlpriv->works.ips_nic_off_wq,
After further testing, this patch is OK. The problem I saw had another source.
Add Tested-by: Larry Finger
Larry
next prev parent reply other threads:[~2010-12-18 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 19:59 [RFT] rtlwifi: use alloc_workqueue John W. Linville
2010-12-17 3:45 ` Larry Finger
2010-12-17 9:57 ` Tejun Heo
2010-12-18 1:29 ` Larry Finger [this message]
2010-12-18 7:13 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0C0E5F.4030605@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).