* Compile error for the last week inside rtlwifi/base.c @ 2010-12-28 6:58 Weedy 2010-12-28 16:23 ` Larry Finger 0 siblings, 1 reply; 6+ messages in thread From: Weedy @ 2010-12-28 6:58 UTC (permalink / raw) To: linux-wireless I'm not sure if my kernel is too old or what but since nothing has changed I'm going to ask. CC [M] /media/8G_SDcard/compat-wireless-2010-12-26-pc/drivers/net/wireless/rtlwifi/ base.o /media/8G_SDcard/compat-wireless-2010-12-26-pc/drivers/net/wireless/rtlwifi/ base.c: In function ‘_rtl_init_deferred_work’: /media/8G_SDcard/compat-wireless-2010-12-26-pc/drivers/net/wireless/rtlwifi/ base.c:229: error: implicit declaration of function ‘alloc_workqueue’ /media/8G_SDcard/compat-wireless-2010-12-26-pc/drivers/net/wireless/rtlwifi/ base.c:229: warning: assignment makes pointer from integer without a cast make[4]: *** [/media/8G_SDcard/compat-wireless-2010-12-26-pc/drivers/net/ wireless/rtlwifi/base.o] Error 1 make[3]: *** [/media/8G_SDcard/compat-wireless-2010-12-26-pc/drivers/net/ wireless/rtlwifi] Error 2 make[2]: *** [/media/8G_SDcard/compat-wireless-2010-12-26-pc/drivers/net/ wireless] Error 2 make[1]: *** [_module_/media/8G_SDcard/compat-wireless-2010-12-26-pc] Error 2 make[1]: Leaving directory `/usr/src/linux-headers-2.6.35-24-generic-pae' make: *** [modules] Error 2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Compile error for the last week inside rtlwifi/base.c 2010-12-28 6:58 Compile error for the last week inside rtlwifi/base.c Weedy @ 2010-12-28 16:23 ` Larry Finger 2010-12-29 2:43 ` Weedy 0 siblings, 1 reply; 6+ messages in thread From: Larry Finger @ 2010-12-28 16:23 UTC (permalink / raw) To: Weedy; +Cc: linux-wireless [-- Attachment #1: Type: text/plain, Size: 992 bytes --] On 12/28/2010 12:58 AM, Weedy wrote: > I'm not sure if my kernel is too old or what but since nothing has changed I'm > going to ask. Older kernels used create_workqueue(), which is replaced by alloc_workqueue(). If you really need the driver for RTL8192CE/RTL8188CE, then apply the patch shown below. If you do not need the driver, then disable it in the configuration. Larry --- diff --git a/drivers/net/wireless/rtlwifi/base.c b/drivers/net/wireless/rtlwifi/base.c index 77fa59a..f6cc073 100644 --- a/drivers/net/wireless/rtlwifi/base.c +++ b/drivers/net/wireless/rtlwifi/base.c @@ -225,7 +225,7 @@ static void _rtl_init_deferred_work(struct ieee80211_hw *hw) /* <2> work queue */ rtlpriv->works.hw = hw; ` rtlpriv->works.rtl_wq = alloc_workqueue(rtlpriv->cfg->name, 0, 0); + rtlpriv->works.rtl_wq = create_workqueue(rtlpriv->cfg->name); INIT_DELAYED_WORK(&rtlpriv->works.watchdog_wq, (void *)rtl_watchdog_wq_callback); INIT_DELAYED_WORK(&rtlpriv->works.ips_nic_off_wq, [-- Attachment #2: reverse_alloc --] [-- Type: text/plain, Size: 1087 bytes --] commit 3d986b25b5faa50ba6afd94f60f270b6c3061e5e Author: John W. Linville <linville@tuxdriver.com> Date: Thu Dec 16 14:59:49 2010 -0500 rtlwifi: use alloc_workqueue create_workqueue is deprecated. The workqueue usage does not seem to demand any special treatment, so do not set any flags either. Signed-off-by: John W. Linville <linville@tuxdriver.com> Tested-by: Larry Finger <Larry.Finger@lwfinger.net> Acked-by: Tejun Heo <tj@kernel.org> diff --git a/drivers/net/wireless/rtlwifi/base.c b/drivers/net/wireless/rtlwifi/base.c index 77fa59a..f6cc073 100644 --- a/drivers/net/wireless/rtlwifi/base.c +++ b/drivers/net/wireless/rtlwifi/base.c @@ -225,7 +225,7 @@ static void _rtl_init_deferred_work(struct ieee80211_hw *hw) /* <2> work queue */ rtlpriv->works.hw = hw; - rtlpriv->works.rtl_wq = create_workqueue(rtlpriv->cfg->name); + rtlpriv->works.rtl_wq = alloc_workqueue(rtlpriv->cfg->name, 0, 0); INIT_DELAYED_WORK(&rtlpriv->works.watchdog_wq, (void *)rtl_watchdog_wq_callback); INIT_DELAYED_WORK(&rtlpriv->works.ips_nic_off_wq, ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: Compile error for the last week inside rtlwifi/base.c 2010-12-28 16:23 ` Larry Finger @ 2010-12-29 2:43 ` Weedy 2010-12-29 3:44 ` Larry Finger 2010-12-29 16:56 ` Larry Finger 0 siblings, 2 replies; 6+ messages in thread From: Weedy @ 2010-12-29 2:43 UTC (permalink / raw) To: linux-wireless Larry Finger <Larry.Finger@...> writes: > Older kernels used create_workqueue(), which is replaced by alloc_workqueue() > If you really need the driver for RTL8192CE/RTL8188CE, then apply the patch > shown below. If you do not need the driver, then disable it in the > configuration. > > Larry Actually I need RTL8192USB, I guess I need to wait more? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Compile error for the last week inside rtlwifi/base.c 2010-12-29 2:43 ` Weedy @ 2010-12-29 3:44 ` Larry Finger 2010-12-29 16:56 ` Larry Finger 1 sibling, 0 replies; 6+ messages in thread From: Larry Finger @ 2010-12-29 3:44 UTC (permalink / raw) To: Weedy; +Cc: linux-wireless On 12/28/2010 08:43 PM, Weedy wrote: > Larry Finger <Larry.Finger@...> writes: > >> Older kernels used create_workqueue(), which is replaced by alloc_workqueue() >> If you really need the driver for RTL8192CE/RTL8188CE, then apply the patch >> shown below. If you do not need the driver, then disable it in the >> configuration. >> >> Larry > > Actually I need RTL8192USB, I guess I need to wait more? Yes. The rtlwifi driver is for PCIe devices. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Compile error for the last week inside rtlwifi/base.c 2010-12-29 2:43 ` Weedy 2010-12-29 3:44 ` Larry Finger @ 2010-12-29 16:56 ` Larry Finger 2010-12-31 8:24 ` Weedy 1 sibling, 1 reply; 6+ messages in thread From: Larry Finger @ 2010-12-29 16:56 UTC (permalink / raw) To: Weedy; +Cc: linux-wireless On 12/28/2010 08:43 PM, Weedy wrote: > Larry Finger <Larry.Finger@...> writes: > >> Older kernels used create_workqueue(), which is replaced by alloc_workqueue() >> If you really need the driver for RTL8192CE/RTL8188CE, then apply the patch >> shown below. If you do not need the driver, then disable it in the >> configuration. >> >> Larry > > Actually I need RTL8192USB, I guess I need to wait more? What are the USB Ids as shown by the lsusb command? Larry ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Compile error for the last week inside rtlwifi/base.c 2010-12-29 16:56 ` Larry Finger @ 2010-12-31 8:24 ` Weedy 0 siblings, 0 replies; 6+ messages in thread From: Weedy @ 2010-12-31 8:24 UTC (permalink / raw) To: linux-wireless Larry Finger <Larry.Finger@...> writes: > > On 12/28/2010 08:43 PM, Weedy wrote: > > Larry Finger <Larry.Finger@...> writes: > > > > Actually I need RTL8192USB, I guess I need to wait more? > > What are the USB Ids as shown by the lsusb command? > > Larry idVendor 0x0bda Realtek Semiconductor Corp. idProduct 0x8171 RTL8188SU 802.11n WLAN Adapter ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-12-31 8:25 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-12-28 6:58 Compile error for the last week inside rtlwifi/base.c Weedy 2010-12-28 16:23 ` Larry Finger 2010-12-29 2:43 ` Weedy 2010-12-29 3:44 ` Larry Finger 2010-12-29 16:56 ` Larry Finger 2010-12-31 8:24 ` Weedy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).