From: Larry Finger <Larry.Finger@lwfinger.net>
To: Christoph Paasch <christoph.paasch@uclouvain.be>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
chunkeey@googlemail.com
Subject: Re: [PATCH] p54: fix compiler-warning when no P54_LEDS are configured
Date: Wed, 29 Dec 2010 10:19:47 -0600 [thread overview]
Message-ID: <4D1B5FA3.9010908@lwfinger.net> (raw)
In-Reply-To: <1293635679-9783-1-git-send-email-christoph.paasch@uclouvain.be>
On 12/29/2010 09:14 AM, Christoph Paasch wrote:
> The priv-variable is unused when compiling without CONFIG_P54_LEDS.
>
> Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
> ---
> drivers/net/wireless/p54/main.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/p54/main.c b/drivers/net/wireless/p54/main.c
> index 622d27b..a6802f5 100644
> --- a/drivers/net/wireless/p54/main.c
> +++ b/drivers/net/wireless/p54/main.c
> @@ -611,7 +611,9 @@ EXPORT_SYMBOL_GPL(p54_init_common);
>
> int p54_register_common(struct ieee80211_hw *dev, struct device *pdev)
> {
> +#ifdef CONFIG_P54_LEDS
> struct p54_common *priv = dev->priv;
> +#endif /* CONFIG_P54_LEDS */
> int err;
>
> err = ieee80211_register_hw(dev);
> @@ -653,9 +655,9 @@ EXPORT_SYMBOL_GPL(p54_free_common);
>
> void p54_unregister_common(struct ieee80211_hw *dev)
> {
> +#ifdef CONFIG_P54_LEDS
> struct p54_common *priv = dev->priv;
>
> -#ifdef CONFIG_P54_LEDS
> p54_unregister_leds(priv);
> #endif /* CONFIG_P54_LEDS */
>
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
next prev parent reply other threads:[~2010-12-29 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 15:14 [PATCH] p54: fix compiler-warning when no P54_LEDS are configured Christoph Paasch
2010-12-29 16:19 ` Larry Finger [this message]
2010-12-29 16:46 ` Larry Finger
2010-12-29 17:16 ` Christoph Paasch
2010-12-29 17:32 ` Larry Finger
2010-12-29 18:13 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1B5FA3.9010908@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=christoph.paasch@uclouvain.be \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).