From: Mohammed Shafi <mshajakhan@atheros.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: Jouni Malinen <Jouni.Malinen@Atheros.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>
Subject: Re: [PATCH] ath9k: Reset keycache on resume
Date: Mon, 3 Jan 2011 10:26:06 +0530 [thread overview]
Message-ID: <4D2156E6.7040307@atheros.com> (raw)
In-Reply-To: <8762u9ge8m.fsf@purkki.adurom.net>
On Saturday 01 January 2011 03:03 PM, Kalle Valo wrote:
> Hi,
>
> a minor nitpick:
>
Thanks for pointing it out.
> Mohammed Shafi Shajakhan<mshajakhan@atheros.com> writes:
>
>
>> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>
> This means that Mohammed is the author of the patch.
>
> [...]
>
Jouni is the author.
>
>> Signed-off-by: Jouni Malinen<Jouni.Malinen@Atheros.com>
>> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>
> But here the author's sob line should be first one, the order is from
> top to bottom. If Mohammed is the author, the sob lines should be
> reversed. But if Jouni actually is the author, the From line should be
> fixed.
>
> Of course this is just a style issue and doesn't matter that much, but
> it's still nice to get it right.
>
>
prev parent reply other threads:[~2011-01-03 4:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 6:50 [PATCH] ath9k: Reset keycache on resume Mohammed Shafi Shajakhan
2011-01-01 9:33 ` Kalle Valo
2011-01-03 4:56 ` Mohammed Shafi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2156E6.7040307@atheros.com \
--to=mshajakhan@atheros.com \
--cc=Jouni.Malinen@Atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).