linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Philip Prindeville <philipp_subx@redfish-solutions.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: Breakage in rtlwifi/base.c for 2010-12-24
Date: Tue, 04 Jan 2011 15:05:07 -0600	[thread overview]
Message-ID: <4D238B83.7020607@lwfinger.net> (raw)
In-Reply-To: <4D237C41.70607@redfish-solutions.com>

On 01/04/2011 02:00 PM, Philip Prindeville wrote:
> Anyone else seeing the following breakage?  I'm building the 2010-12-24
> snapshot against 2.6.27.49:
> 
>   CC [M] 
> /home/philipp/astlinux/build_i586/compat-wireless-2010-12-24/drivers/net/wireless/rtlwifi/base.o
> 
> /home/philipp/astlinux/build_i586/compat-wireless-2010-12-24/drivers/net/wireless/rtlwifi/base.c:
> In function '_rtl_init_deferred_work':
> /home/philipp/astlinux/build_i586/compat-wireless-2010-12-24/drivers/net/wireless/rtlwifi/base.c:229:
> error: implicit declaration of function 'alloc_workqueue'
> /home/philipp/astlinux/build_i586/compat-wireless-2010-12-24/drivers/net/wireless/rtlwifi/base.c:229:
> warning: assignment makes pointer from integer without a cast

The call create_workqueue() is obsolete and is being replaced by
alloc_workqueue(). Unfortunately, older kernels do not have the newer call. A
patch for compat-wireless has been submitted, but I don't think the package has
rebuilt successfully since then. You have two options: (1) if you do not need a
driver for the RTL8192CE/RTL8187CE cards, then deselect them from the build, or
(2) Find the line in drivers/net/wireless/rtlwifi/base.c that says
       rtlpriv->works.rtl_wq = alloc_workqueue(rtlpriv->cfg->name, 0, 0);
and replace it with
       rtlpriv->works.rtl_wq = create_workqueue(rtlpriv->cfg->name);

Larry

      reply	other threads:[~2011-01-04 21:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04 20:00 Breakage in rtlwifi/base.c for 2010-12-24 Philip Prindeville
2011-01-04 21:05 ` Larry Finger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D238B83.7020607@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=philipp_subx@redfish-solutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).