linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Matt Turner <mattst88@gmail.com>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
	Michael Guntsche <mike@it-loops.com>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [ath9k] skbuff alloc of size 3872 failed
Date: Thu, 06 Jan 2011 15:53:10 -0800	[thread overview]
Message-ID: <4D2655E6.3020304@candelatech.com> (raw)
In-Reply-To: <AANLkTi=GUN7=AQAAvmgADgwHtcquNiZbWEtgCoJpC4Fv@mail.gmail.com>

On 12/22/2010 11:22 AM, Matt Turner wrote:
> With the ath9k driver, I get "skbuff alloc of size 3872 failed"
>
> I hit this again today after not using wireless for quite sometime. It
> looks like it was originally reported against 2.6.35-rc1. Eric Dumazet
> provided a patch which fixed the issue, but apparently it's still not
> upstream. Why is this?
>
> If it is suitable for upstream inclusion, please take my Tested-by:
> Matt Turner<mattst88@gmail.com>
>
> https://patchwork.kernel.org/patch/104271/

I applied this patch and it seems to work fine, but there
were some questions by Eric in the patchwork thread that should probably
be answered by ath9k folks.

For instance:

IEEE80211_MAX_MPDU_LEN being 3840 + somebits is suspect, since it doesnt
match 802.11 specs.

It should be more close of 2304 + MAC header (32bytes) + FCS (4 bytes) ?


Eric:  If the patch is fine as is, and if you are too busy to
submit it, I can do so with your Signed-off-by if you want.

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  parent reply	other threads:[~2011-01-06 23:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-22 19:22 [ath9k] skbuff alloc of size 3872 failed Matt Turner
2010-12-22 19:39 ` Luis R. Rodriguez
2011-01-06 23:53 ` Ben Greear [this message]
2011-01-07  0:04   ` Eric Dumazet
2011-01-07  0:05   ` [ath9k-devel] " Luis R. Rodriguez
2011-01-07  0:09     ` Eric Dumazet
2011-01-07  0:12       ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2655E6.3020304@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath9k-devel@venema.h4ckr.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=mike@it-loops.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).