[ath9k] skbuff alloc of size 3872 failed

[ath9k] skbuff alloc of size 3872 failed

[Matt Turner]

With the ath9k driver, I get "skbuff alloc of size 3872 failed"

I hit this again today after not using wireless for quite sometime. It
looks like it was originally reported against 2.6.35-rc1. Eric Dumazet
provided a patch which fixed the issue, but apparently it's still not
upstream. Why is this?

If it is suitable for upstream inclusion, please take my Tested-by:
Matt Turner <mattst88@gmail.com>

https://patchwork.kernel.org/patch/104271/

Thanks,
Matt

Re: [ath9k] skbuff alloc of size 3872 failed

[Luis R. Rodriguez]

On Wed, Dec 22, 2010 at 2:22 PM, Matt Turner <mattst88@gmail.com> wrote:
> With the ath9k driver, I get "skbuff alloc of size 3872 failed"
>
> I hit this again today after not using wireless for quite sometime. It
> looks like it was originally reported against 2.6.35-rc1. Eric Dumazet
> provided a patch which fixed the issue, but apparently it's still not
> upstream. Why is this?
>
> If it is suitable for upstream inclusion, please take my Tested-by:
> Matt Turner <mattst88@gmail.com>
>
> https://patchwork.kernel.org/patch/104271/

Never saw this patch, can this be posted to linux-wireless with a proper SOB?

 Luis

Re: [ath9k] skbuff alloc of size 3872 failed

[Ben Greear]

On 12/22/2010 11:22 AM, Matt Turner wrote:
> With the ath9k driver, I get "skbuff alloc of size 3872 failed"
>
> I hit this again today after not using wireless for quite sometime. It
> looks like it was originally reported against 2.6.35-rc1. Eric Dumazet
> provided a patch which fixed the issue, but apparently it's still not
> upstream. Why is this?
>
> If it is suitable for upstream inclusion, please take my Tested-by:
> Matt Turner<mattst88@gmail.com>
>
> https://patchwork.kernel.org/patch/104271/

I applied this patch and it seems to work fine, but there
were some questions by Eric in the patchwork thread that should probably
be answered by ath9k folks.

For instance:

IEEE80211_MAX_MPDU_LEN being 3840 + somebits is suspect, since it doesnt
match 802.11 specs.

It should be more close of 2304 + MAC header (32bytes) + FCS (4 bytes) ?


Eric:  If the patch is fine as is, and if you are too busy to
submit it, I can do so with your Signed-off-by if you want.

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: [ath9k] skbuff alloc of size 3872 failed

[Eric Dumazet]

Le jeudi 06 janvier 2011 à 15:53 -0800, Ben Greear a écrit :
> On 12/22/2010 11:22 AM, Matt Turner wrote:
> > With the ath9k driver, I get "skbuff alloc of size 3872 failed"
> >
> > I hit this again today after not using wireless for quite sometime. It
> > looks like it was originally reported against 2.6.35-rc1. Eric Dumazet
> > provided a patch which fixed the issue, but apparently it's still not
> > upstream. Why is this?
> >
> > If it is suitable for upstream inclusion, please take my Tested-by:
> > Matt Turner<mattst88@gmail.com>
> >
> > https://patchwork.kernel.org/patch/104271/
> 
> I applied this patch and it seems to work fine, but there
> were some questions by Eric in the patchwork thread that should probably
> be answered by ath9k folks.
> 
> For instance:
> 
> IEEE80211_MAX_MPDU_LEN being 3840 + somebits is suspect, since it doesnt
> match 802.11 specs.
> 
> It should be more close of 2304 + MAC header (32bytes) + FCS (4 bytes) ?
> 
> 
> Eric:  If the patch is fine as is, and if you are too busy to
> submit it, I can do so with your Signed-off-by if you want.
> 

Well, problem is I dont have this hardware and various reports were very
confusing.

Certainly a word from authors/maintainers of this driver is wanted ;)

Thanks !

Re: [ath9k-devel] [ath9k] skbuff alloc of size 3872 failed

[Luis R. Rodriguez]

On Thu, Jan 6, 2011 at 3:53 PM, Ben Greear <greearb@candelatech.com> wrote:
> On 12/22/2010 11:22 AM, Matt Turner wrote:
>> With the ath9k driver, I get "skbuff alloc of size 3872 failed"
>>
>> I hit this again today after not using wireless for quite sometime. It
>> looks like it was originally reported against 2.6.35-rc1. Eric Dumazet
>> provided a patch which fixed the issue, but apparently it's still not
>> upstream. Why is this?
>>
>> If it is suitable for upstream inclusion, please take my Tested-by:
>> Matt Turner<mattst88@gmail.com>
>>
>> https://patchwork.kernel.org/patch/104271/
>
> I applied this patch and it seems to work fine, but there
> were some questions by Eric in the patchwork thread that should probably
> be answered by ath9k folks.
>
> For instance:
>
> IEEE80211_MAX_MPDU_LEN being 3840 + somebits is suspect, since it doesnt
> match 802.11 specs.
>
> It should be more close of 2304 + MAC header (32bytes) + FCS (4 bytes) ?
>
>
> Eric:  If the patch is fine as is, and if you are too busy to
> submit it, I can do so with your Signed-off-by if you want.

Eric, also please make sure you read and understand what using a SOB means:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=HEAD#l309

  Luis

Re: [ath9k-devel] [ath9k] skbuff alloc of size 3872 failed

[Eric Dumazet]

Le jeudi 06 janvier 2011 à 16:05 -0800, Luis R. Rodriguez a écrit :

> Eric, also please make sure you read and understand what using a SOB means:
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=HEAD#l309
> 
>   Luis

You must be kidding.

Re: [ath9k-devel] [ath9k] skbuff alloc of size 3872 failed

[Luis R. Rodriguez]

On Thu, Jan 6, 2011 at 4:09 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le jeudi 06 janvier 2011 à 16:05 -0800, Luis R. Rodriguez a écrit :
>
>> Eric, also please make sure you read and understand what using a SOB means:
>>
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=HEAD#l309
>>
>>   Luis
>
> You must be kidding.

Heh actually sorry, I confused you with a first-patch-submitter.

  Luis