Re: [ath9k-devel] [PATCH v2 3/3] ath9k: Keep track of stations for debugfs.

[Felix Fietkau <nbd@openwrt.org>]

On 2011-01-07 1:12 PM, Luis R. Rodriguez wrote:
> On Thu, Jan 06, 2011 at 08:49:12PM -0800, greearb@candelatech.com wrote:
>>  From: Ben Greear<greearb@candelatech.com>
>>
>>  The stations hold the ath_node, which holds the tid
>>  and other xmit logic structures.  In order to debug
>>  stuck xmit logic, we need a way to print out the tid
>>  state for the stations.
>>
>>  Signed-off-by: Ben Greear<greearb@candelatech.com>
>>  ---
>>
>>  v1 ->  v2:  Use linked list instead of array.  Protect with spinlock.
>
> Again, see my comments about the # STAs limit. I think this can go in
> as a cfg80211 driver limitation which can be exposed. If you want to go
> over the supported number (known to work, safe, call it what you want)
> then a kconfig option can be used.
I disagree with putting in an essentially arbitrary restriction based on 
what has been tested, unless we can actually point at a *specific* 
limitation that makes the limit necessary.
If ath9k gets unstable with too many STA interfaces, then we should 
identify the underlying cause or fix it.

- Felix