[PATCH] mac80211: Fix skb-copy failure debug message.

[PATCH] mac80211: Fix skb-copy failure debug message.

[greearb]

From: Ben Greear <greearb@candelatech.com>

This particular error isn't about multicast.

Signed-off-by: Ben Greear <greearb@candelatech.com>
---
:100644 100644 a6701ed... 6d2c59b... M	net/mac80211/rx.c
 net/mac80211/rx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index a6701ed..6d2c59b 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -2692,7 +2692,7 @@ static bool ieee80211_prepare_and_rx_handle(struct ieee80211_rx_data *rx,
 		if (!skb) {
 			if (net_ratelimit())
 				wiphy_debug(local->hw.wiphy,
-					"failed to copy multicast frame for %s\n",
+					"failed to copy skb for %s\n",
 					sdata->name);
 			return true;
 		}
-- 
1.7.2.3

Re: [PATCH] mac80211: Fix skb-copy failure debug message.

[Johannes Berg]

On Sat, 2011-01-08 at 10:30 -0800, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> This particular error isn't about multicast.

Actually, it is... only multicast frames should ever be processed by
multiple interfaces.

johannes

Re: [PATCH] mac80211: Fix skb-copy failure debug message.

[Ben Greear]

On 01/09/2011 01:32 AM, Johannes Berg wrote:
> On Sat, 2011-01-08 at 10:30 -0800, greearb@candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> This particular error isn't about multicast.
>
> Actually, it is... only multicast frames should ever be processed by
> multiple interfaces.

Or if the STA interfaces are promisc for some reason..but no big
deal either way.  With the old ath9k code, even arps or dhcp requests
would be an order-1 SKB, so that is probably what I was seeing.

I had a clean overnight run with the ath9k copybreak logic, so
that seems to have been the root problem.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com