From: Ben Greear <greearb@candelatech.com>
To: Vasanthakumar Thiagarajan <vasanth@Atheros.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath9k-devel@venema.h4ckr.net" <ath9k-devel@venema.h4ckr.net>
Subject: Re: [PATCH 2/2] ath9k: Fix incorrect tx-hang detection logic.
Date: Sun, 09 Jan 2011 21:48:54 -0800 [thread overview]
Message-ID: <4D2A9DC6.1030405@candelatech.com> (raw)
In-Reply-To: <20110110053835.GB5656@vasanth-laptop>
On 01/09/2011 09:38 PM, Vasanthakumar Thiagarajan wrote:
> On Fri, Jan 07, 2011 at 11:30:59PM +0530, greearb@candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> It is not guaranteed that the ath_tx_complete_poll_work runs
>> after some fixed duration because the channel-reset logic
>> removes the work and then re-adds it to run immediately.
>> Two channel-changes 1ms apart, with a transmit was being
>> attempted, could thus incorrectly trigger a reset by
>> the ath_tx_complete_poll_work method.
>
> I don't think so. axq_tx_inprogress is reset in ath_draintxq().
Ahhh, I see now.
I'll remove this patch from my queue and make sure it still runs
as well.
Thanks,
Ben
>
> Vasanth
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2011-01-10 5:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 18:00 [PATCH 1/2] ath9k: More xmit queue debugfs information greearb
2011-01-07 18:00 ` [PATCH 2/2] ath9k: Fix incorrect tx-hang detection logic greearb
2011-01-10 5:38 ` Vasanthakumar Thiagarajan
2011-01-10 5:48 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2A9DC6.1030405@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=linux-wireless@vger.kernel.org \
--cc=vasanth@Atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).